Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Unified Diff: Source/bindings/core/v8/custom/V8CustomEventCustom.cpp

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp b/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
index 055565a9f19fcf0b1398323b9d9c73504531589a..d7113aa44001b28869ee283844a98710c4b7f517 100644
--- a/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp
@@ -65,7 +65,7 @@ void V8CustomEvent::detailAttributeGetterCustom(const v8::PropertyCallbackInfo<v
// we need to find the 'detail' property on the main world wrapper and clone it.
v8::Local<v8::Value> mainWorldDetail = V8HiddenValue::getHiddenValueFromMainWorldWrapper(info.GetIsolate(), event, V8HiddenValue::detail(info.GetIsolate()));
if (!mainWorldDetail.IsEmpty())
- event->setSerializedDetail(SerializedScriptValue::createAndSwallowExceptions(mainWorldDetail, info.GetIsolate()));
+ event->setSerializedDetail(SerializedScriptValue::createAndSwallowExceptions(info.GetIsolate(), mainWorldDetail));
}
if (event->serializedDetail()) {
@@ -92,7 +92,7 @@ void V8CustomEvent::initCustomEventMethodCustom(const v8::FunctionCallbackInfo<v
if (!detailsArg.IsEmpty()) {
V8HiddenValue::setHiddenValue(info.GetIsolate(), info.Holder(), V8HiddenValue::detail(info.GetIsolate()), detailsArg);
if (DOMWrapperWorld::current(info.GetIsolate()).isIsolatedWorld())
- event->setSerializedDetail(SerializedScriptValue::createAndSwallowExceptions(detailsArg, info.GetIsolate()));
+ event->setSerializedDetail(SerializedScriptValue::createAndSwallowExceptions(info.GetIsolate(), detailsArg));
}
}
« no previous file with comments | « Source/bindings/core/v8/WorkerScriptController.cpp ('k') | Source/bindings/core/v8/custom/V8DocumentCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698