Source/bindings/core/v8/V8ErrorHandler.h - Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ErrorHandler.h

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8ErrorHandler.h

diff --git a/Source/bindings/core/v8/V8ErrorHandler.h b/Source/bindings/core/v8/V8ErrorHandler.h

index bed945b65fc8936d8f207426d6bd2b6367898f39..8c886626e8fb80aefd2342d37d9e3a4c7a2de0e6 100644

--- a/Source/bindings/core/v8/V8ErrorHandler.h

+++ b/Source/bindings/core/v8/V8ErrorHandler.h

@@ -46,7 +46,7 @@ public:

return adoptRef(new V8ErrorHandler(listener, isInline, scriptState));

}

- static void storeExceptionOnErrorEventWrapper(ErrorEvent*, v8::Handle<v8::Value>, v8::Handle<v8::Object> creationContext, v8::Isolate*);

+ static void storeExceptionOnErrorEventWrapper(v8::Isolate*, ErrorEvent*, v8::Handle<v8::Value>, v8::Handle<v8::Object> creationContext);

private:

V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, ScriptState*);

« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/core/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »