Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/core/v8/custom/V8MessageEventCustom.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
diff --git a/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp b/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
index 1b2d570f5210d4eb0030fdd3177fd29a8c293919..c7a2fc8e0949960deb2d35afea756f8ba25151e6 100644
--- a/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
+++ b/Source/bindings/core/v8/custom/V8PopStateEventCustom.cpp
@@ -63,7 +63,7 @@ void V8PopStateEvent::stateAttributeGetterCustom(const v8::PropertyCallbackInfo<
// we need to find the 'state' property on the main world wrapper and clone it.
v8::Local<v8::Value> mainWorldState = V8HiddenValue::getHiddenValueFromMainWorldWrapper(info.GetIsolate(), event, V8HiddenValue::state(info.GetIsolate()));
if (!mainWorldState.IsEmpty())
- event->setSerializedState(SerializedScriptValue::createAndSwallowExceptions(mainWorldState, info.GetIsolate()));
+ event->setSerializedState(SerializedScriptValue::createAndSwallowExceptions(info.GetIsolate(), mainWorldState));
}
if (event->serializedState())
result = event->serializedState()->deserialize();
« no previous file with comments | « Source/bindings/core/v8/custom/V8MessageEventCustom.cpp ('k') | Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698