Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/V8ErrorHandler.h ('k') | Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 tryCatch.SetVerbose(true); 72 tryCatch.SetVerbose(true);
73 if (scriptState()->executionContext()->isWorkerGlobalScope()) 73 if (scriptState()->executionContext()->isWorkerGlobalScope())
74 returnValue = V8ScriptRunner::callFunction(callFunction, scriptState ()->executionContext(), thisValue, WTF_ARRAY_LENGTH(parameters), parameters, iso late()); 74 returnValue = V8ScriptRunner::callFunction(callFunction, scriptState ()->executionContext(), thisValue, WTF_ARRAY_LENGTH(parameters), parameters, iso late());
75 else 75 else
76 returnValue = ScriptController::callFunction(scriptState()->executio nContext(), callFunction, thisValue, WTF_ARRAY_LENGTH(parameters), parameters, i solate()); 76 returnValue = ScriptController::callFunction(scriptState()->executio nContext(), callFunction, thisValue, WTF_ARRAY_LENGTH(parameters), parameters, i solate());
77 } 77 }
78 return returnValue; 78 return returnValue;
79 } 79 }
80 80
81 // static 81 // static
82 void V8ErrorHandler::storeExceptionOnErrorEventWrapper(ErrorEvent* event, v8::Ha ndle<v8::Value> data, v8::Handle<v8::Object> creationContext, v8::Isolate* isola te) 82 void V8ErrorHandler::storeExceptionOnErrorEventWrapper(v8::Isolate* isolate, Err orEvent* event, v8::Handle<v8::Value> data, v8::Handle<v8::Object> creationConte xt)
83 { 83 {
84 v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, isolate); 84 v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, isolate);
85 if (!wrappedEvent.IsEmpty()) { 85 if (!wrappedEvent.IsEmpty()) {
86 ASSERT(wrappedEvent->IsObject()); 86 ASSERT(wrappedEvent->IsObject());
87 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data); 87 V8HiddenValue::setHiddenValue(isolate, v8::Local<v8::Object>::Cast(wrapp edEvent), V8HiddenValue::error(isolate), data);
88 } 88 }
89 } 89 }
90 90
91 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue) 91 bool V8ErrorHandler::shouldPreventDefault(v8::Local<v8::Value> returnValue)
92 { 92 {
93 return returnValue->IsBoolean() && returnValue->BooleanValue(); 93 return returnValue->IsBoolean() && returnValue->BooleanValue();
94 } 94 }
95 95
96 } // namespace blink 96 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8ErrorHandler.h ('k') | Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698