Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Side by Side Diff: Source/bindings/core/v8/V8ErrorHandler.h

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/core/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 39
40 class ErrorEvent; 40 class ErrorEvent;
41 41
42 class V8ErrorHandler final : public V8EventListener { 42 class V8ErrorHandler final : public V8EventListener {
43 public: 43 public:
44 static PassRefPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, boo l isInline, ScriptState* scriptState) 44 static PassRefPtr<V8ErrorHandler> create(v8::Local<v8::Object> listener, boo l isInline, ScriptState* scriptState)
45 { 45 {
46 return adoptRef(new V8ErrorHandler(listener, isInline, scriptState)); 46 return adoptRef(new V8ErrorHandler(listener, isInline, scriptState));
47 } 47 }
48 48
49 static void storeExceptionOnErrorEventWrapper(ErrorEvent*, v8::Handle<v8::Va lue>, v8::Handle<v8::Object> creationContext, v8::Isolate*); 49 static void storeExceptionOnErrorEventWrapper(v8::Isolate*, ErrorEvent*, v8: :Handle<v8::Value>, v8::Handle<v8::Object> creationContext);
50 50
51 private: 51 private:
52 V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, ScriptState*); 52 V8ErrorHandler(v8::Local<v8::Object> listener, bool isInline, ScriptState*);
53 53
54 virtual v8::Local<v8::Value> callListenerFunction(v8::Handle<v8::Value> jsEv ent, Event*) override; 54 virtual v8::Local<v8::Value> callListenerFunction(v8::Handle<v8::Value> jsEv ent, Event*) override;
55 virtual bool shouldPreventDefault(v8::Local<v8::Value> returnValue) override ; 55 virtual bool shouldPreventDefault(v8::Local<v8::Value> returnValue) override ;
56 }; 56 };
57 57
58 } // namespace blink 58 } // namespace blink
59 59
60 #endif // V8ErrorHandler_h 60 #endif // V8ErrorHandler_h
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/core/v8/V8ErrorHandler.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698