Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: Source/bindings/core/v8/SerializedScriptValue.cpp

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/SerializedScriptValue.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 2784 matching lines...) Expand 10 before | Expand all | Expand 10 after
2795 uint32_t m_version; 2795 uint32_t m_version;
2796 }; 2796 };
2797 2797
2798 } // namespace 2798 } // namespace
2799 2799
2800 PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(v8::Handle<v8::V alue> value, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, Exc eptionState& exceptionState, v8::Isolate* isolate) 2800 PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(v8::Handle<v8::V alue> value, MessagePortArray* messagePorts, ArrayBufferArray* arrayBuffers, Exc eptionState& exceptionState, v8::Isolate* isolate)
2801 { 2801 {
2802 return adoptRef(new SerializedScriptValue(value, messagePorts, arrayBuffers, 0, exceptionState, isolate)); 2802 return adoptRef(new SerializedScriptValue(value, messagePorts, arrayBuffers, 0, exceptionState, isolate));
2803 } 2803 }
2804 2804
2805 PassRefPtr<SerializedScriptValue> SerializedScriptValue::createAndSwallowExcepti ons(v8::Handle<v8::Value> value, v8::Isolate* isolate) 2805 PassRefPtr<SerializedScriptValue> SerializedScriptValue::createAndSwallowExcepti ons(v8::Isolate* isolate, v8::Handle<v8::Value> value)
2806 { 2806 {
2807 TrackExceptionState exceptionState; 2807 TrackExceptionState exceptionState;
2808 return adoptRef(new SerializedScriptValue(value, 0, 0, 0, exceptionState, is olate)); 2808 return adoptRef(new SerializedScriptValue(value, 0, 0, 0, exceptionState, is olate));
2809 } 2809 }
2810 2810
2811 PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(const ScriptValu e& value, WebBlobInfoArray* blobInfo, ExceptionState& exceptionState, v8::Isolat e* isolate) 2811 PassRefPtr<SerializedScriptValue> SerializedScriptValue::create(const ScriptValu e& value, WebBlobInfoArray* blobInfo, ExceptionState& exceptionState, v8::Isolat e* isolate)
2812 { 2812 {
2813 ASSERT(isolate->InContext()); 2813 ASSERT(isolate->InContext());
2814 return adoptRef(new SerializedScriptValue(value.v8Value(), 0, 0, blobInfo, e xceptionState, isolate)); 2814 return adoptRef(new SerializedScriptValue(value.v8Value(), 0, 0, blobInfo, e xceptionState, isolate));
2815 } 2815 }
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
3065 // If the allocated memory was not registered before, then this class is lik ely 3065 // If the allocated memory was not registered before, then this class is lik ely
3066 // used in a context other then Worker's onmessage environment and the prese nce of 3066 // used in a context other then Worker's onmessage environment and the prese nce of
3067 // current v8 context is not guaranteed. Avoid calling v8 then. 3067 // current v8 context is not guaranteed. Avoid calling v8 then.
3068 if (m_externallyAllocatedMemory) { 3068 if (m_externallyAllocatedMemory) {
3069 ASSERT(v8::Isolate::GetCurrent()); 3069 ASSERT(v8::Isolate::GetCurrent());
3070 v8::Isolate::GetCurrent()->AdjustAmountOfExternalAllocatedMemory(-m_exte rnallyAllocatedMemory); 3070 v8::Isolate::GetCurrent()->AdjustAmountOfExternalAllocatedMemory(-m_exte rnallyAllocatedMemory);
3071 } 3071 }
3072 } 3072 }
3073 3073
3074 } // namespace blink 3074 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/SerializedScriptValue.h ('k') | Source/bindings/core/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698