Source/bindings/core/v8/V8ErrorHandler.cpp - Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ErrorHandler.cpp

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8ErrorHandler.cpp

diff --git a/Source/bindings/core/v8/V8ErrorHandler.cpp b/Source/bindings/core/v8/V8ErrorHandler.cpp

index 547f05398741e8f1068b0202df6a87dd9e3e7df7..0a3c9b69f89320d5de3d29010ac05d7329a6cbe0 100644

--- a/Source/bindings/core/v8/V8ErrorHandler.cpp

+++ b/Source/bindings/core/v8/V8ErrorHandler.cpp

@@ -79,7 +79,7 @@ v8::Local<v8::Value> V8ErrorHandler::callListenerFunction(v8::Handle<v8::Value>

}

// static

-void V8ErrorHandler::storeExceptionOnErrorEventWrapper(ErrorEvent* event, v8::Handle<v8::Value> data, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate)

+void V8ErrorHandler::storeExceptionOnErrorEventWrapper(v8::Isolate* isolate, ErrorEvent* event, v8::Handle<v8::Value> data, v8::Handle<v8::Object> creationContext)

{

v8::Local<v8::Value> wrappedEvent = toV8(event, creationContext, isolate);

if (!wrappedEvent.IsEmpty()) {

« no previous file with comments | « Source/bindings/core/v8/V8ErrorHandler.h ('k') | Source/bindings/core/v8/V8Initializer.cpp » ('j') | no next file with comments »