Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: Source/bindings/core/v8/V8Binding.cpp

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8ErrorHandler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 667 matching lines...) Expand 10 before | Expand all | Expand 10 after
678 return String(); 678 return String();
679 } 679 }
680 680
681 // USVString is identical to DOMString except that "convert a 681 // USVString is identical to DOMString except that "convert a
682 // DOMString to a sequence of Unicode characters" is used subsequently 682 // DOMString to a sequence of Unicode characters" is used subsequently
683 // when converting to an IDL value 683 // when converting to an IDL value
684 String x = toCoreString(stringObject); 684 String x = toCoreString(stringObject);
685 return replaceUnmatchedSurrogates(x); 685 return replaceUnmatchedSurrogates(x);
686 } 686 }
687 687
688 PassRefPtrWillBeRawPtr<XPathNSResolver> toXPathNSResolver(v8::Handle<v8::Value> value, v8::Isolate* isolate) 688 PassRefPtrWillBeRawPtr<XPathNSResolver> toXPathNSResolver(v8::Isolate* isolate, v8::Handle<v8::Value> value)
689 { 689 {
690 RefPtrWillBeRawPtr<XPathNSResolver> resolver = nullptr; 690 RefPtrWillBeRawPtr<XPathNSResolver> resolver = nullptr;
691 if (V8XPathNSResolver::hasInstance(value, isolate)) 691 if (V8XPathNSResolver::hasInstance(value, isolate))
692 resolver = V8XPathNSResolver::toImpl(v8::Handle<v8::Object>::Cast(value) ); 692 resolver = V8XPathNSResolver::toImpl(v8::Handle<v8::Object>::Cast(value) );
693 else if (value->IsObject()) 693 else if (value->IsObject())
694 resolver = V8CustomXPathNSResolver::create(value->ToObject(), isolate); 694 resolver = V8CustomXPathNSResolver::create(value->ToObject(), isolate);
695 return resolver; 695 return resolver;
696 } 696 }
697 697
698 LocalDOMWindow* toDOMWindow(v8::Handle<v8::Value> value, v8::Isolate* isolate) 698 LocalDOMWindow* toDOMWindow(v8::Handle<v8::Value> value, v8::Isolate* isolate)
(...skipping 294 matching lines...) Expand 10 before | Expand all | Expand 10 after
993 993
994 v8::Local<v8::Value> v8IteratorResult(v8::Isolate* isolate, v8::Handle<v8::Value > value) 994 v8::Local<v8::Value> v8IteratorResult(v8::Isolate* isolate, v8::Handle<v8::Value > value)
995 { 995 {
996 v8::Local<v8::Object> result = v8::Object::New(isolate); 996 v8::Local<v8::Object> result = v8::Object::New(isolate);
997 result->Set(v8String(isolate, "value"), value); 997 result->Set(v8String(isolate, "value"), value);
998 result->Set(v8String(isolate, "done"), v8Boolean(false, isolate)); 998 result->Set(v8String(isolate, "done"), v8Boolean(false, isolate));
999 return result; 999 return result;
1000 } 1000 }
1001 1001
1002 } // namespace blink 1002 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8Binding.h ('k') | Source/bindings/core/v8/V8ErrorHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698