Source/bindings/core/v8/custom/V8DocumentCustom.cpp - Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/custom/V8DocumentCustom.cpp

Issue 686103005: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | Source/bindings/core/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/custom/V8DocumentCustom.cpp

diff --git a/Source/bindings/core/v8/custom/V8DocumentCustom.cpp b/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

index b9aced5f448ee3ab4b681acd3340eb0c5a2a5a30..82f47066f6fcf466c7fce43dd7f240606f898b3d 100644

--- a/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

+++ b/Source/bindings/core/v8/custom/V8DocumentCustom.cpp

@@ -67,7 +67,7 @@ void V8Document::evaluateMethodCustom(const v8::FunctionCallbackInfo<v8::Value>&

RefPtrWillBeRawPtr<Node> contextNode = V8Node::toImplWithTypeCheck(info.GetIsolate(), info[1]);

const int resolverArgumentIndex = 2;

- RefPtrWillBeRawPtr<XPathNSResolver> resolver = toXPathNSResolver(info[resolverArgumentIndex], info.GetIsolate());

+ RefPtrWillBeRawPtr<XPathNSResolver> resolver = toXPathNSResolver(info.GetIsolate(), info[resolverArgumentIndex]);

if (!resolver && !isUndefinedOrNull(info[resolverArgumentIndex])) {

exceptionState.throwTypeError(ExceptionMessages::argumentNullOrIncorrectType(resolverArgumentIndex + 1, "XPathNSResolver"));

exceptionState.throwIfNeeded();

« no previous file with comments | « Source/bindings/core/v8/custom/V8CustomEventCustom.cpp ('k') | Source/bindings/core/v8/custom/V8MessageEventCustom.cpp » ('j') | no next file with comments »