Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 675193002: Revert of Added varying struct (Closed)

Created:
6 years, 2 months ago by joshualitt
Modified:
6 years, 2 months ago
Reviewers:
bsalomon, joshua.litt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@gp_emit_struct
Project:
skia
Visibility:
Public.

Description

Revert of Added varying struct (patchset #9 id:160001 of https://codereview.chromium.org/671023002/) Reason for revert: may have caused gm change on arm Original issue's description: > Added varying struct > > TBR= > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/852ae80b9c3c6fd53f993ac35133d80863993cbe TBR=bsalomon@google.com,joshualitt@chromium.org NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/c6f3e2c17b3a7ccfd1ca473652ee9e34e89fad0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+269 lines, -313 lines) Patch
M include/gpu/GrGeometryProcessor.h View 3 chunks +1 line, -7 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +20 lines, -20 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 4 chunks +23 lines, -21 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 3 chunks +60 lines, -65 lines 0 comments Download
M src/gpu/effects/GrBezierEffect.cpp View 12 chunks +50 lines, -47 lines 0 comments Download
M src/gpu/effects/GrCustomCoordsTextureEffect.cpp View 1 chunk +9 lines, -6 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldTextureEffect.cpp View 8 chunks +23 lines, -14 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 4 chunks +9 lines, -9 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +9 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.h View 1 chunk +3 lines, -7 lines 0 comments Download
M src/gpu/gl/builders/GrGLGeometryShaderBuilder.cpp View 1 chunk +15 lines, -16 lines 0 comments Download
M src/gpu/gl/builders/GrGLNvprProgramBuilder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +7 lines, -55 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 3 chunks +12 lines, -17 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLVertexShaderBuilder.cpp View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
joshualitt
Created Revert of Added varying struct
6 years, 2 months ago (2014-10-24 15:23:09 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675193002/1
6 years, 2 months ago (2014-10-24 15:23:52 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 15:24:13 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as c6f3e2c17b3a7ccfd1ca473652ee9e34e89fad0a

Powered by Google App Engine
This is Rietveld 408576698