Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 1 month ago
Reviewers:
tapted
CC:
chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/apps/ BUG=417463 TBR=tapted@chromium.org Committed: https://crrev.com/57e2620b250eeec9fe8a4a959c458582f5cdf280 Cr-Commit-Position: refs/heads/master@{#300442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -275 lines) Patch
M chrome/browser/apps/app_browsertest.cc View 4 chunks +11 lines, -15 lines 0 comments Download
M chrome/browser/apps/app_browsertest_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_handler_mac.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_mac.h View 3 chunks +10 lines, -11 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc View 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm View 4 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_host_manager_mac.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm View 2 chunks +7 lines, -11 lines 0 comments Download
M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h View 2 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/apps/app_url_redirector_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/app_view_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/apps/app_window_browsertest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_converter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_converter.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_converter_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/drive/drive_app_provider.h View 2 chunks +8 lines, -10 lines 0 comments Download
M chrome/browser/apps/drive/drive_app_provider_browsertest.cc View 6 chunks +9 lines, -13 lines 0 comments Download
M chrome/browser/apps/drive/drive_service_bridge.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_browsertest.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_browsertest.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher.h View 2 chunks +20 lines, -22 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_launcher_browsertest.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service.h View 2 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/apps/ephemeral_app_service_factory.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/apps/install_chrome_app.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/apps/per_app_settings_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/per_app_settings_service_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/apps/shortcut_manager.h View 1 chunk +10 lines, -13 lines 0 comments Download
M chrome/browser/apps/shortcut_manager_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/apps/speech_recognition_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/apps/web_view_browsertest.cc View 9 chunks +18 lines, -22 lines 0 comments Download
M chrome/browser/apps/web_view_interactive_browsertest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/apps/window_controls_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:24:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/668903002/1
6 years, 2 months ago (2014-10-21 09:25:40 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 10:24:11 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/57e2620b250eeec9fe8a4a959c458582f5cdf280 Cr-Commit-Position: refs/heads/master@{#300442}
6 years, 2 months ago (2014-10-21 10:24:59 UTC) #5
tapted
6 years, 1 month ago (2014-11-03 06:33:55 UTC) #6
Message was sent while issue was closed. 
sweet! lgtm

Powered by Google App Engine
This is Rietveld 408576698