chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc - Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_shim/extension_app_shim_handler_mac.h ('k') | chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

diff --git a/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc b/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

index 6223af348706ee50b8723afe509731c3ebfa3ceb..23d360a616aad328e7eee872b3c073c28700b97b 100644

--- a/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

+++ b/chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc

@@ -92,8 +92,7 @@ class EnableViaPrompt : public ExtensionEnableFlowDelegate {

callback_(callback) {

}

- virtual ~EnableViaPrompt() {

- }

+ ~EnableViaPrompt() override {}

void Run() {

flow_.reset(new ExtensionEnableFlow(profile_, extension_id_, this));

@@ -103,12 +102,12 @@ class EnableViaPrompt : public ExtensionEnableFlowDelegate {

private:

// ExtensionEnableFlowDelegate overrides.

- virtual void ExtensionEnableFlowFinished() override {

+ void ExtensionEnableFlowFinished() override {

callback_.Run();

delete this;

}

- virtual void ExtensionEnableFlowAborted(bool user_initiated) override {

+ void ExtensionEnableFlowAborted(bool user_initiated) override {

callback_.Run();

delete this;

}