chrome/browser/apps/install_chrome_app.cc - Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/install_chrome_app.cc

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/install_chrome_app.cc

diff --git a/chrome/browser/apps/install_chrome_app.cc b/chrome/browser/apps/install_chrome_app.cc

index 1b9bd49dd79e3c54adccb1f550e3b864f883d4c4..167e8d5c6bfabad797996e2695843dc598d69834 100644

--- a/chrome/browser/apps/install_chrome_app.cc

+++ b/chrome/browser/apps/install_chrome_app.cc

@@ -51,10 +51,10 @@ class WebstoreInstallWithPromptAppsOnly

extensions::WebstoreStandaloneInstaller::Callback()) {}

private:

- virtual ~WebstoreInstallWithPromptAppsOnly() {}

+ ~WebstoreInstallWithPromptAppsOnly() override {}

// extensions::WebstoreStandaloneInstaller overrides:

- virtual void OnManifestParsed() override;

+ void OnManifestParsed() override;

DISALLOW_COPY_AND_ASSIGN(WebstoreInstallWithPromptAppsOnly);

};

« no previous file with comments | « chrome/browser/apps/ephemeral_app_service_factory.h ('k') | chrome/browser/apps/per_app_settings_service.h » ('j') | no next file with comments »