Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1838)

Unified Diff: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
diff --git a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
index ecac1be62c1d6a26029d9a01439d20a63be5a176..56db665cb147847052ab8da14660244f8b72cce3 100644
--- a/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
+++ b/chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm
@@ -124,9 +124,9 @@ class WindowedAppShimLaunchObserver : public apps::AppShimHandler {
}
// AppShimHandler overrides:
- virtual void OnShimLaunch(Host* host,
- apps::AppShimLaunchType launch_type,
- const std::vector<base::FilePath>& files) override {
+ void OnShimLaunch(Host* host,
+ apps::AppShimLaunchType launch_type,
+ const std::vector<base::FilePath>& files) override {
// Remove self and pass through to the default handler.
apps::AppShimHandler::RemoveHandler(app_mode_id_);
apps::AppShimHandler::GetForAppMode(app_mode_id_)
@@ -135,12 +135,12 @@ class WindowedAppShimLaunchObserver : public apps::AppShimHandler {
if (run_loop_.get())
run_loop_->Quit();
}
- virtual void OnShimClose(Host* host) override {}
- virtual void OnShimFocus(Host* host,
- apps::AppShimFocusType focus_type,
- const std::vector<base::FilePath>& files) override {}
- virtual void OnShimSetHidden(Host* host, bool hidden) override {}
- virtual void OnShimQuit(Host* host) override {}
+ void OnShimClose(Host* host) override {}
+ void OnShimFocus(Host* host,
+ apps::AppShimFocusType focus_type,
+ const std::vector<base::FilePath>& files) override {}
+ void OnShimSetHidden(Host* host, bool hidden) override {}
+ void OnShimQuit(Host* host) override {}
private:
std::string app_mode_id_;

Powered by Google App Engine
This is Rietveld 408576698