chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h - Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_shim/extension_app_shim_handler_mac.cc ('k') | chrome/browser/apps/app_url_redirector_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h

diff --git a/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h b/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h

index 19a03d1b095013a6aee1640f367ad79c74407297..a402178ff435f59a4e40a6aecbeaddd866843511 100644

--- a/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h

+++ b/chrome/browser/apps/app_shim/unix_domain_socket_acceptor.h

@@ -30,7 +30,7 @@ class UnixDomainSocketAcceptor : public base::MessageLoopForIO::Watcher {

UnixDomainSocketAcceptor(const base::FilePath& path, Delegate* delegate);

- virtual ~UnixDomainSocketAcceptor();

+ ~UnixDomainSocketAcceptor() override;

// Call this to start listening on the socket.

bool Listen();

@@ -40,8 +40,8 @@ class UnixDomainSocketAcceptor : public base::MessageLoopForIO::Watcher {

private:

bool CreateSocket();

- virtual void OnFileCanReadWithoutBlocking(int fd) override;

- virtual void OnFileCanWriteWithoutBlocking(int fd) override;

+ void OnFileCanReadWithoutBlocking(int fd) override;

+ void OnFileCanWriteWithoutBlocking(int fd) override;

base::MessageLoopForIO::FileDescriptorWatcher

server_listen_connection_watcher_;