chrome/browser/apps/drive/drive_app_converter.h - Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/drive/drive_app_converter.h

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/apps/drive/drive_app_converter.h

diff --git a/chrome/browser/apps/drive/drive_app_converter.h b/chrome/browser/apps/drive/drive_app_converter.h

index dca629d913fd9f35b2f92f70ae62e0881f333762..515f9ef67005a38714e4efcdbaf5e706cba19335 100644

--- a/chrome/browser/apps/drive/drive_app_converter.h

+++ b/chrome/browser/apps/drive/drive_app_converter.h

@@ -32,7 +32,7 @@ class DriveAppConverter : public extensions::InstallObserver {

DriveAppConverter(Profile* profile,

const drive::DriveAppInfo& drive_app_info,

const FinishedCallback& finished_callback);

- virtual ~DriveAppConverter();

+ ~DriveAppConverter() override;

void Start();

bool IsStarted() const;

@@ -53,8 +53,8 @@ class DriveAppConverter : public extensions::InstallObserver {

void PostInstallCleanUp();

// extensions::InstallObserver:

- virtual void OnFinishCrxInstall(const std::string& extension_id,

- bool success) override;

+ void OnFinishCrxInstall(const std::string& extension_id,

+ bool success) override;

Profile* profile_;

const drive::DriveAppInfo drive_app_info_;

« no previous file with comments | « chrome/browser/apps/app_window_browsertest.cc ('k') | chrome/browser/apps/drive/drive_app_converter.cc » ('j') | no next file with comments »