Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1024)

Unified Diff: chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
diff --git a/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc b/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
index 1a5f110b25b849e9363d323912e48373f26a2722..9b8b9d96c6548706ebaacf08754b14cd3e3e8e5f 100644
--- a/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
+++ b/chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc
@@ -17,7 +17,7 @@ namespace {
class TestingAppShimHost : public AppShimHost {
public:
TestingAppShimHost() {}
- virtual ~TestingAppShimHost() {}
+ ~TestingAppShimHost() override {}
bool ReceiveMessage(IPC::Message* message);
@@ -26,7 +26,7 @@ class TestingAppShimHost : public AppShimHost {
}
protected:
- virtual bool Send(IPC::Message* message) override;
+ bool Send(IPC::Message* message) override;
private:
ScopedVector<IPC::Message> sent_messages_;
@@ -82,26 +82,26 @@ class AppShimHostTest : public testing::Test,
}
protected:
- virtual void OnShimLaunch(Host* host,
- apps::AppShimLaunchType launch_type,
- const std::vector<base::FilePath>& file) override {
+ void OnShimLaunch(Host* host,
+ apps::AppShimLaunchType launch_type,
+ const std::vector<base::FilePath>& file) override {
++launch_count_;
if (launch_type == apps::APP_SHIM_LAUNCH_NORMAL)
++launch_now_count_;
host->OnAppLaunchComplete(launch_result_);
}
- virtual void OnShimClose(Host* host) override { ++close_count_; }
+ void OnShimClose(Host* host) override { ++close_count_; }
- virtual void OnShimFocus(Host* host,
- apps::AppShimFocusType focus_type,
- const std::vector<base::FilePath>& file) override {
+ void OnShimFocus(Host* host,
+ apps::AppShimFocusType focus_type,
+ const std::vector<base::FilePath>& file) override {
++focus_count_;
}
- virtual void OnShimSetHidden(Host* host, bool hidden) override {}
+ void OnShimSetHidden(Host* host, bool hidden) override {}
- virtual void OnShimQuit(Host* host) override { ++quit_count_; }
+ void OnShimQuit(Host* host) override { ++quit_count_; }
apps::AppShimLaunchResult launch_result_;
int launch_count_;

Powered by Google App Engine
This is Rietveld 408576698