chrome/browser/apps/app_shim/app_shim_host_manager_mac.h - Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_shim/app_shim_host_manager_mac.h

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/app_shim/app_shim_host_manager_browsertest_mac.mm ('k') | chrome/browser/apps/app_shim/app_shim_interactive_uitest_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_shim/app_shim_host_manager_mac.h

diff --git a/chrome/browser/apps/app_shim/app_shim_host_manager_mac.h b/chrome/browser/apps/app_shim/app_shim_host_manager_mac.h

index 26a174c482a018485e0424c03ff3c46541379119..3ac45b182c8f3a460fdcce5608e1610ad5191a51 100644

--- a/chrome/browser/apps/app_shim/app_shim_host_manager_mac.h

+++ b/chrome/browser/apps/app_shim/app_shim_host_manager_mac.h

@@ -45,8 +45,8 @@ class AppShimHostManager : public apps::UnixDomainSocketAcceptor::Delegate,

virtual ~AppShimHostManager();

// UnixDomainSocketAcceptor::Delegate implementation.

- virtual void OnClientConnected(const IPC::ChannelHandle& handle) override;

- virtual void OnListenError() override;

+ void OnClientConnected(const IPC::ChannelHandle& handle) override;

+ void OnListenError() override;

// The |acceptor_| must be created on a thread which allows blocking I/O, so

// part of the initialization of this class must be carried out on the file