Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5452)

Unified Diff: chrome/browser/apps/app_shim/app_shim_host_mac.h

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_host_mac.h
diff --git a/chrome/browser/apps/app_shim/app_shim_host_mac.h b/chrome/browser/apps/app_shim/app_shim_host_mac.h
index a3088808b5612954742f1a9be8e04863a0ddbc02..31b8c1b40c424a8d027a5ce8a12ac955a594bcee 100644
--- a/chrome/browser/apps/app_shim/app_shim_host_mac.h
+++ b/chrome/browser/apps/app_shim/app_shim_host_mac.h
@@ -31,7 +31,7 @@ class AppShimHost : public IPC::Listener,
public base::NonThreadSafe {
public:
AppShimHost();
- virtual ~AppShimHost();
+ ~AppShimHost() override;
// Creates a new server-side IPC channel at |handle|, which should contain a
// file descriptor of a channel created by an UnixDomainSocketAcceptor,
@@ -40,11 +40,11 @@ class AppShimHost : public IPC::Listener,
protected:
// IPC::Listener implementation.
- virtual bool OnMessageReceived(const IPC::Message& message) override;
- virtual void OnChannelError() override;
+ bool OnMessageReceived(const IPC::Message& message) override;
+ void OnChannelError() override;
// IPC::Sender implementation.
- virtual bool Send(IPC::Message* message) override;
+ bool Send(IPC::Message* message) override;
private:
// The app shim process is requesting to be associated with the given profile
@@ -66,13 +66,12 @@ class AppShimHost : public IPC::Listener,
void OnQuit();
// apps::AppShimHandler::Host overrides:
- virtual void OnAppLaunchComplete(apps::AppShimLaunchResult result) override;
- virtual void OnAppClosed() override;
- virtual void OnAppHide() override;
- virtual void OnAppRequestUserAttention(
- apps::AppShimAttentionType type) override;
- virtual base::FilePath GetProfilePath() const override;
- virtual std::string GetAppId() const override;
+ void OnAppLaunchComplete(apps::AppShimLaunchResult result) override;
+ void OnAppClosed() override;
+ void OnAppHide() override;
+ void OnAppRequestUserAttention(apps::AppShimAttentionType type) override;
+ base::FilePath GetProfilePath() const override;
+ std::string GetAppId() const override;
// Closes the channel and destroys the AppShimHost.
void Close();
« no previous file with comments | « chrome/browser/apps/app_shim/app_shim_handler_mac.cc ('k') | chrome/browser/apps/app_shim/app_shim_host_mac_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698