chrome/browser/apps/drive/drive_app_provider.h - Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/drive/drive_app_provider.h

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/apps/drive/drive_app_converter_browsertest.cc ('k') | chrome/browser/apps/drive/drive_app_provider_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/drive/drive_app_provider.h

diff --git a/chrome/browser/apps/drive/drive_app_provider.h b/chrome/browser/apps/drive/drive_app_provider.h

index 7f077434e14a2fed3b9f128409d88872214ddbcf..7fc1b26ea304993dd18ee681b4e7ad398c7b7f5a 100644

--- a/chrome/browser/apps/drive/drive_app_provider.h

+++ b/chrome/browser/apps/drive/drive_app_provider.h

@@ -38,7 +38,7 @@ class DriveAppProvider : public drive::DriveAppRegistryObserver,

public:

DriveAppProvider(Profile* profile,

DriveAppUninstallSyncService* uninstall_sync_service);

- virtual ~DriveAppProvider();

+ ~DriveAppProvider() override;

// Appends PKS factories this class depends on.

static void AppendDependsOnFactories(

@@ -80,17 +80,15 @@ class DriveAppProvider : public drive::DriveAppRegistryObserver,

void UpdateDriveApps();

// drive::DriveAppRegistryObserver overrides:

- virtual void OnDriveAppRegistryUpdated() override;

+ void OnDriveAppRegistryUpdated() override;

// extensions::ExtensionRegistryObserver overrides:

- virtual void OnExtensionInstalled(

- content::BrowserContext* browser_context,

- const extensions::Extension* extension,

- bool is_update) override;

- virtual void OnExtensionUninstalled(

- content::BrowserContext* browser_context,

- const extensions::Extension* extension,

- extensions::UninstallReason reason) override;

+ void OnExtensionInstalled(content::BrowserContext* browser_context,

+ const extensions::Extension* extension,

+ bool is_update) override;

+ void OnExtensionUninstalled(content::BrowserContext* browser_context,

+ const extensions::Extension* extension,

+ extensions::UninstallReason reason) override;

Profile* profile_;

DriveAppUninstallSyncService* uninstall_sync_service_;