Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1342)

Unified Diff: chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm

Issue 668903002: Standardize usage of virtual/override/final in chrome/browser/apps/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm
diff --git a/chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm b/chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm
index f4605057fe3e31978d641e8c2ec91f847269c030..15b3f35542bbbd47d184a3f595b56d027b4a8cd1 100644
--- a/chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm
+++ b/chrome/browser/apps/app_shim/app_shim_quit_interactive_uitest_mac.mm
@@ -36,16 +36,12 @@ class FakeHost : public apps::AppShimHandler::Host {
app_id_(app_id),
handler_(handler) {}
- virtual void OnAppLaunchComplete(AppShimLaunchResult result) override {}
- virtual void OnAppClosed() override {
- handler_->OnShimClose(this);
- }
- virtual void OnAppHide() override {}
- virtual void OnAppRequestUserAttention(AppShimAttentionType type) override {}
- virtual base::FilePath GetProfilePath() const override {
- return profile_path_;
- }
- virtual std::string GetAppId() const override { return app_id_; }
+ void OnAppLaunchComplete(AppShimLaunchResult result) override {}
+ void OnAppClosed() override { handler_->OnShimClose(this); }
+ void OnAppHide() override {}
+ void OnAppRequestUserAttention(AppShimAttentionType type) override {}
+ base::FilePath GetProfilePath() const override { return profile_path_; }
+ std::string GetAppId() const override { return app_id_; }
private:
base::FilePath profile_path_;
@@ -89,7 +85,7 @@ class AppShimQuitTest : public PlatformAppBrowserTest {
content::RunAllPendingInMessageLoop();
}
- virtual void SetUpCommandLine(CommandLine* command_line) override {
+ void SetUpCommandLine(CommandLine* command_line) override {
PlatformAppBrowserTest::SetUpCommandLine(command_line);
// Simulate an app shim initiated launch, i.e. launch app but not browser.
app_path_ = test_data_dir_

Powered by Google App Engine
This is Rietveld 408576698