Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
tzik
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=tzik@chromium.org Committed: https://crrev.com/9a74ddccb2e98ec53906278be3705274b95e500c Cr-Commit-Position: refs/heads/master@{#300453}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+454 lines, -501 lines) Patch
M chrome/browser/sync_file_system/drive_backend/conflict_resolver.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h View 2 chunks +37 lines, -37 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.h View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h View 1 chunk +30 lines, -33 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/list_changes_task.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index.h View 1 chunk +32 lines, -33 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.h View 1 chunk +34 lines, -34 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/register_app_task.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_change_processor_on_worker.h View 1 chunk +12 lines, -14 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.h View 2 chunks +37 lines, -43 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_initializer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager_unittest.cc View 4 chunks +11 lines, -16 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker.h View 1 chunk +34 lines, -35 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/uninstall_app_task.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/fake_remote_change_processor.h View 1 chunk +12 lines, -14 lines 0 comments Download
M chrome/browser/sync_file_system/local/canned_syncable_file_system.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker.h View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_context.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service.h View 2 chunks +13 lines, -16 lines 0 comments Download
M chrome/browser/sync_file_system/local/local_file_sync_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/sync_file_system_backend.h View 2 chunks +23 lines, -24 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_operation_runner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.h View 1 chunk +62 lines, -64 lines 0 comments Download
M chrome/browser/sync_file_system/local/syncable_file_system_operation.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.h View 4 chunks +20 lines, -23 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner.cc View 1 chunk +6 lines, -10 lines 0 comments Download
M chrome/browser/sync_file_system/sync_process_runner_unittest.cc View 3 chunks +11 lines, -20 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:09:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666143002/1
6 years, 2 months ago (2014-10-21 10:09:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:09:34 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:10:13 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/9a74ddccb2e98ec53906278be3705274b95e500c
Cr-Commit-Position: refs/heads/master@{#300453}

Powered by Google App Engine
This is Rietveld 408576698