Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1415)

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index.h
diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h b/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h
index 7c983ec528e0905c6ed2d88d08eea51a98cad407..9c80060d8fe7cda7a9b1a589566e6fbd4d8520ac 100644
--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h
+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index.h
@@ -58,49 +58,48 @@ struct DatabaseContents {
// Maintains indexes of MetadataDatabase on memory.
class MetadataDatabaseIndex : public MetadataDatabaseIndexInterface {
public:
- virtual ~MetadataDatabaseIndex();
+ ~MetadataDatabaseIndex() override;
static scoped_ptr<MetadataDatabaseIndex> Create(LevelDBWrapper* db);
static scoped_ptr<MetadataDatabaseIndex> CreateForTesting(
DatabaseContents* contents, LevelDBWrapper* db);
// MetadataDatabaseIndexInterface overrides.
- virtual bool GetFileMetadata(
- const std::string& file_id, FileMetadata* metadata) const override;
- virtual bool GetFileTracker(
- int64 tracker_id, FileTracker* tracker) const override;
- virtual void StoreFileMetadata(scoped_ptr<FileMetadata> metadata) override;
- virtual void StoreFileTracker(scoped_ptr<FileTracker> tracker) override;
- virtual void RemoveFileMetadata(const std::string& file_id) override;
- virtual void RemoveFileTracker(int64 tracker_id) override;
- virtual TrackerIDSet GetFileTrackerIDsByFileID(
+ bool GetFileMetadata(const std::string& file_id,
+ FileMetadata* metadata) const override;
+ bool GetFileTracker(int64 tracker_id, FileTracker* tracker) const override;
+ void StoreFileMetadata(scoped_ptr<FileMetadata> metadata) override;
+ void StoreFileTracker(scoped_ptr<FileTracker> tracker) override;
+ void RemoveFileMetadata(const std::string& file_id) override;
+ void RemoveFileTracker(int64 tracker_id) override;
+ TrackerIDSet GetFileTrackerIDsByFileID(
const std::string& file_id) const override;
- virtual int64 GetAppRootTracker(const std::string& app_id) const override;
- virtual TrackerIDSet GetFileTrackerIDsByParentAndTitle(
+ int64 GetAppRootTracker(const std::string& app_id) const override;
+ TrackerIDSet GetFileTrackerIDsByParentAndTitle(
int64 parent_tracker_id,
const std::string& title) const override;
- virtual std::vector<int64> GetFileTrackerIDsByParent(
+ std::vector<int64> GetFileTrackerIDsByParent(
int64 parent_tracker_id) const override;
- virtual std::string PickMultiTrackerFileID() const override;
- virtual ParentIDAndTitle PickMultiBackingFilePath() const override;
- virtual int64 PickDirtyTracker() const override;
- virtual void DemoteDirtyTracker(int64 tracker_id) override;
- virtual bool HasDemotedDirtyTracker() const override;
- virtual bool IsDemotedDirtyTracker(int64 tracker_id) const override;
- virtual void PromoteDemotedDirtyTracker(int64 tracker_id) override;
- virtual bool PromoteDemotedDirtyTrackers() override;
- virtual size_t CountDirtyTracker() const override;
- virtual size_t CountFileMetadata() const override;
- virtual size_t CountFileTracker() const override;
- virtual void SetSyncRootTrackerID(int64 sync_root_id) const override;
- virtual void SetLargestChangeID(int64 largest_change_id) const override;
- virtual void SetNextTrackerID(int64 next_tracker_id) const override;
- virtual int64 GetSyncRootTrackerID() const override;
- virtual int64 GetLargestChangeID() const override;
- virtual int64 GetNextTrackerID() const override;
- virtual std::vector<std::string> GetRegisteredAppIDs() const override;
- virtual std::vector<int64> GetAllTrackerIDs() const override;
- virtual std::vector<std::string> GetAllMetadataIDs() const override;
+ std::string PickMultiTrackerFileID() const override;
+ ParentIDAndTitle PickMultiBackingFilePath() const override;
+ int64 PickDirtyTracker() const override;
+ void DemoteDirtyTracker(int64 tracker_id) override;
+ bool HasDemotedDirtyTracker() const override;
+ bool IsDemotedDirtyTracker(int64 tracker_id) const override;
+ void PromoteDemotedDirtyTracker(int64 tracker_id) override;
+ bool PromoteDemotedDirtyTrackers() override;
+ size_t CountDirtyTracker() const override;
+ size_t CountFileMetadata() const override;
+ size_t CountFileTracker() const override;
+ void SetSyncRootTrackerID(int64 sync_root_id) const override;
+ void SetLargestChangeID(int64 largest_change_id) const override;
+ void SetNextTrackerID(int64 next_tracker_id) const override;
+ int64 GetSyncRootTrackerID() const override;
+ int64 GetLargestChangeID() const override;
+ int64 GetNextTrackerID() const override;
+ std::vector<std::string> GetRegisteredAppIDs() const override;
+ std::vector<int64> GetAllTrackerIDs() const override;
+ std::vector<std::string> GetAllMetadataIDs() const override;
private:
typedef base::ScopedPtrHashMap<std::string, FileMetadata> MetadataByID;

Powered by Google App Engine
This is Rietveld 408576698