chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h - Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.h ('k') | chrome/browser/sync_file_system/drive_backend/fake_sync_worker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h

diff --git a/chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h b/chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h

index 7ff3652009495be63effc23378717e79bb9906fa..65b216766b821ca57b46df536e3cb50b54da0b09 100644

--- a/chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h

+++ b/chrome/browser/sync_file_system/drive_backend/fake_drive_uploader.h

@@ -23,10 +23,10 @@ namespace drive_backend {

class FakeDriveServiceWrapper : public drive::FakeDriveService {

public:

FakeDriveServiceWrapper();

- virtual ~FakeDriveServiceWrapper();

+ ~FakeDriveServiceWrapper() override;

// DriveServiceInterface overrides.

- virtual google_apis::CancelCallback AddNewDirectory(

+ google_apis::CancelCallback AddNewDirectory(

const std::string& parent_resource_id,

const std::string& directory_name,

const AddNewDirectoryOptions& options,

@@ -47,10 +47,10 @@ class FakeDriveServiceWrapper : public drive::FakeDriveService {

class FakeDriveUploader : public drive::DriveUploaderInterface {

public:

explicit FakeDriveUploader(FakeDriveServiceWrapper* fake_drive_service);

- virtual ~FakeDriveUploader();

+ ~FakeDriveUploader() override;

// DriveUploaderInterface overrides.

- virtual google_apis::CancelCallback UploadNewFile(

+ google_apis::CancelCallback UploadNewFile(

const std::string& parent_resource_id,

const base::FilePath& local_file_path,

const std::string& title,

@@ -58,14 +58,14 @@ class FakeDriveUploader : public drive::DriveUploaderInterface {

const UploadNewFileOptions& options,

const drive::UploadCompletionCallback& callback,

const google_apis::ProgressCallback& progress_callback) override;

- virtual google_apis::CancelCallback UploadExistingFile(

+ google_apis::CancelCallback UploadExistingFile(

const std::string& resource_id,

const base::FilePath& local_file_path,

const std::string& content_type,

const UploadExistingFileOptions& options,

const drive::UploadCompletionCallback& callback,

const google_apis::ProgressCallback& progress_callback) override;

- virtual google_apis::CancelCallback ResumeUploadFile(

+ google_apis::CancelCallback ResumeUploadFile(

const GURL& upload_location,

const base::FilePath& local_file_path,

const std::string& content_type,