Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Side by Side Diff: chrome/browser/sync_file_system/sync_process_runner_unittest.cc

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/sync_file_system/sync_process_runner.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/sync_file_system/sync_process_runner.h" 5 #include "chrome/browser/sync_file_system/sync_process_runner.h"
6 6
7 #include <queue> 7 #include <queue>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
11 11
12 namespace sync_file_system { 12 namespace sync_file_system {
13 13
14 namespace { 14 namespace {
15 15
16 class FakeClient : public SyncProcessRunner::Client { 16 class FakeClient : public SyncProcessRunner::Client {
17 public: 17 public:
18 FakeClient() : service_state_(SYNC_SERVICE_RUNNING) {} 18 FakeClient() : service_state_(SYNC_SERVICE_RUNNING) {}
19 virtual ~FakeClient() {} 19 ~FakeClient() override {}
20 20
21 virtual SyncServiceState GetSyncServiceState() override { 21 SyncServiceState GetSyncServiceState() override { return service_state_; }
22 return service_state_;
23 }
24 22
25 virtual SyncFileSystemService* GetSyncService() override { 23 SyncFileSystemService* GetSyncService() override { return nullptr; }
26 return nullptr;
27 }
28 24
29 void set_service_state(SyncServiceState service_state) { 25 void set_service_state(SyncServiceState service_state) {
30 service_state_ = service_state; 26 service_state_ = service_state;
31 } 27 }
32 28
33 private: 29 private:
34 SyncServiceState service_state_; 30 SyncServiceState service_state_;
35 31
36 DISALLOW_COPY_AND_ASSIGN(FakeClient); 32 DISALLOW_COPY_AND_ASSIGN(FakeClient);
37 }; 33 };
38 34
39 class FakeTimerHelper : public SyncProcessRunner::TimerHelper { 35 class FakeTimerHelper : public SyncProcessRunner::TimerHelper {
40 public: 36 public:
41 FakeTimerHelper() {} 37 FakeTimerHelper() {}
42 virtual ~FakeTimerHelper() {} 38 ~FakeTimerHelper() override {}
43 39
44 virtual bool IsRunning() override { 40 bool IsRunning() override { return !timer_task_.is_null(); }
45 return !timer_task_.is_null();
46 }
47 41
48 virtual void Start(const tracked_objects::Location& from_here, 42 void Start(const tracked_objects::Location& from_here,
49 const base::TimeDelta& delay, 43 const base::TimeDelta& delay,
50 const base::Closure& closure) override { 44 const base::Closure& closure) override {
51 scheduled_time_ = current_time_ + delay; 45 scheduled_time_ = current_time_ + delay;
52 timer_task_ = closure; 46 timer_task_ = closure;
53 } 47 }
54 48
55 virtual base::TimeTicks Now() const override { 49 base::TimeTicks Now() const override { return current_time_; }
56 return current_time_;
57 }
58 50
59 void SetCurrentTime(const base::TimeTicks& current_time) { 51 void SetCurrentTime(const base::TimeTicks& current_time) {
60 current_time_ = current_time; 52 current_time_ = current_time;
61 if (current_time_ < scheduled_time_ || timer_task_.is_null()) 53 if (current_time_ < scheduled_time_ || timer_task_.is_null())
62 return; 54 return;
63 55
64 base::Closure task = timer_task_; 56 base::Closure task = timer_task_;
65 timer_task_.Reset(); 57 timer_task_.Reset();
66 task.Run(); 58 task.Run();
67 } 59 }
(...skipping 19 matching lines...) Expand all
87 public: 79 public:
88 FakeSyncProcessRunner(SyncProcessRunner::Client* client, 80 FakeSyncProcessRunner(SyncProcessRunner::Client* client,
89 scoped_ptr<TimerHelper> timer_helper, 81 scoped_ptr<TimerHelper> timer_helper,
90 size_t max_parallel_task) 82 size_t max_parallel_task)
91 : SyncProcessRunner("FakeSyncProcess", 83 : SyncProcessRunner("FakeSyncProcess",
92 client, timer_helper.Pass(), 84 client, timer_helper.Pass(),
93 max_parallel_task), 85 max_parallel_task),
94 max_parallel_task_(max_parallel_task) { 86 max_parallel_task_(max_parallel_task) {
95 } 87 }
96 88
97 virtual void StartSync(const SyncStatusCallback& callback) override { 89 void StartSync(const SyncStatusCallback& callback) override {
98 EXPECT_LT(running_tasks_.size(), max_parallel_task_); 90 EXPECT_LT(running_tasks_.size(), max_parallel_task_);
99 running_tasks_.push(callback); 91 running_tasks_.push(callback);
100 } 92 }
101 93
102 virtual ~FakeSyncProcessRunner() { 94 ~FakeSyncProcessRunner() override {}
103 }
104 95
105 void UpdateChanges(int num_changes) { 96 void UpdateChanges(int num_changes) {
106 OnChangesUpdated(num_changes); 97 OnChangesUpdated(num_changes);
107 } 98 }
108 99
109 void CompleteTask(SyncStatusCode status) { 100 void CompleteTask(SyncStatusCode status) {
110 ASSERT_FALSE(running_tasks_.empty()); 101 ASSERT_FALSE(running_tasks_.empty());
111 SyncStatusCallback task = running_tasks_.front(); 102 SyncStatusCallback task = running_tasks_.front();
112 running_tasks_.pop(); 103 running_tasks_.pop();
113 task.Run(status); 104 task.Run(status);
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 259
269 // Then, following failing task should not extend throttling period. 260 // Then, following failing task should not extend throttling period.
270 fake_timer->AdvanceToScheduledTime(); 261 fake_timer->AdvanceToScheduledTime();
271 fake_client.set_service_state(SYNC_SERVICE_TEMPORARY_UNAVAILABLE); 262 fake_client.set_service_state(SYNC_SERVICE_TEMPORARY_UNAVAILABLE);
272 fake_runner.CompleteTask(SYNC_STATUS_FAILED); 263 fake_runner.CompleteTask(SYNC_STATUS_FAILED);
273 EXPECT_EQ(SyncProcessRunner::kSyncDelaySlowInMilliseconds, 264 EXPECT_EQ(SyncProcessRunner::kSyncDelaySlowInMilliseconds,
274 fake_timer->GetCurrentDelay()); 265 fake_timer->GetCurrentDelay());
275 } 266 }
276 267
277 } // namespace sync_file_system 268 } // namespace sync_file_system
OLDNEW
« no previous file with comments | « chrome/browser/sync_file_system/sync_process_runner.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698