chrome/browser/sync_file_system/local/local_file_change_tracker.h - Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/local_file_change_tracker.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/local/canned_syncable_file_system.h ('k') | chrome/browser/sync_file_system/local/local_file_sync_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/local_file_change_tracker.h

diff --git a/chrome/browser/sync_file_system/local/local_file_change_tracker.h b/chrome/browser/sync_file_system/local/local_file_change_tracker.h

index daf22350e4067692381632a08bcc94d703a9a7b7..d38c8fc4ca52061f08a0c501b99485e38a3b58dd 100644

--- a/chrome/browser/sync_file_system/local/local_file_change_tracker.h

+++ b/chrome/browser/sync_file_system/local/local_file_change_tracker.h

@@ -48,22 +48,21 @@ class LocalFileChangeTracker : public storage::FileUpdateObserver,

LocalFileChangeTracker(const base::FilePath& base_path,

leveldb::Env* env_override,

base::SequencedTaskRunner* file_task_runner);

- virtual ~LocalFileChangeTracker();

+ ~LocalFileChangeTracker() override;

// FileUpdateObserver overrides.

- virtual void OnStartUpdate(const storage::FileSystemURL& url) override;

- virtual void OnUpdate(const storage::FileSystemURL& url,

- int64 delta) override {}

- virtual void OnEndUpdate(const storage::FileSystemURL& url) override;

+ void OnStartUpdate(const storage::FileSystemURL& url) override;

+ void OnUpdate(const storage::FileSystemURL& url, int64 delta) override {}

+ void OnEndUpdate(const storage::FileSystemURL& url) override;

// FileChangeObserver overrides.

- virtual void OnCreateFile(const storage::FileSystemURL& url) override;

- virtual void OnCreateFileFrom(const storage::FileSystemURL& url,

- const storage::FileSystemURL& src) override;

- virtual void OnRemoveFile(const storage::FileSystemURL& url) override;

- virtual void OnModifyFile(const storage::FileSystemURL& url) override;

- virtual void OnCreateDirectory(const storage::FileSystemURL& url) override;

- virtual void OnRemoveDirectory(const storage::FileSystemURL& url) override;

+ void OnCreateFile(const storage::FileSystemURL& url) override;

+ void OnCreateFileFrom(const storage::FileSystemURL& url,

+ const storage::FileSystemURL& src) override;

+ void OnRemoveFile(const storage::FileSystemURL& url) override;

+ void OnModifyFile(const storage::FileSystemURL& url) override;

+ void OnCreateDirectory(const storage::FileSystemURL& url) override;

+ void OnRemoveDirectory(const storage::FileSystemURL& url) override;

// Retrieves an array of |url| which have more than one pending changes.

// If |max_urls| is non-zero (recommended in production code) this