chrome/browser/sync_file_system/local/canned_syncable_file_system.h - Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/canned_syncable_file_system.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/fake_remote_change_processor.h ('k') | chrome/browser/sync_file_system/local/local_file_change_tracker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/canned_syncable_file_system.h

diff --git a/chrome/browser/sync_file_system/local/canned_syncable_file_system.h b/chrome/browser/sync_file_system/local/canned_syncable_file_system.h

index cd7d478136d98b7578b2f86a6d6b455aa35f4ecb..13ebb830d506a0030fc03a452194254002c660ef 100644

--- a/chrome/browser/sync_file_system/local/canned_syncable_file_system.h

+++ b/chrome/browser/sync_file_system/local/canned_syncable_file_system.h

@@ -75,7 +75,7 @@ class CannedSyncableFileSystem

leveldb::Env* env_override,

const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner,

const scoped_refptr<base::SingleThreadTaskRunner>& file_task_runner);

- virtual ~CannedSyncableFileSystem();

+ ~CannedSyncableFileSystem() override;

// SetUp must be called before using this instance.

void SetUp(QuotaMode quota_mode);

@@ -159,8 +159,8 @@ class CannedSyncableFileSystem

storage::FileSystemOperationRunner* operation_runner();

// LocalFileSyncStatus::Observer overrides.

- virtual void OnSyncEnabled(const storage::FileSystemURL& url) override;

- virtual void OnWriteEnabled(const storage::FileSystemURL& url) override;

+ void OnSyncEnabled(const storage::FileSystemURL& url) override;

+ void OnWriteEnabled(const storage::FileSystemURL& url) override;

// Operation methods body.

// They can be also called directly if the caller is already on IO thread.