Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2933)

Unified Diff: chrome/browser/sync_file_system/drive_backend/sync_engine.cc

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync_file_system/drive_backend/sync_engine.cc
diff --git a/chrome/browser/sync_file_system/drive_backend/sync_engine.cc b/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
index e3d843495132dd03a58a9c1f4065d729fa7b8f3d..c0b2fea78c64363048c76b76a9cd58a91674008b 100644
--- a/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
+++ b/chrome/browser/sync_file_system/drive_backend/sync_engine.cc
@@ -89,11 +89,11 @@ class SyncEngine::WorkerObserver : public SyncWorkerInterface::Observer {
sequence_checker_.DetachFromSequence();
}
- virtual ~WorkerObserver() {
+ ~WorkerObserver() override {
DCHECK(sequence_checker_.CalledOnValidSequencedThread());
}
- virtual void OnPendingFileListUpdated(int item_count) override {
+ void OnPendingFileListUpdated(int item_count) override {
if (ui_task_runner_->RunsTasksOnCurrentThread()) {
if (sync_engine_)
sync_engine_->OnPendingFileListUpdated(item_count);
@@ -108,11 +108,11 @@ class SyncEngine::WorkerObserver : public SyncWorkerInterface::Observer {
item_count));
}
- virtual void OnFileStatusChanged(const storage::FileSystemURL& url,
- SyncFileType file_type,
- SyncFileStatus file_status,
- SyncAction sync_action,
- SyncDirection direction) override {
+ void OnFileStatusChanged(const storage::FileSystemURL& url,
+ SyncFileType file_type,
+ SyncFileStatus file_status,
+ SyncAction sync_action,
+ SyncDirection direction) override {
if (ui_task_runner_->RunsTasksOnCurrentThread()) {
if (sync_engine_)
sync_engine_->OnFileStatusChanged(
@@ -128,8 +128,8 @@ class SyncEngine::WorkerObserver : public SyncWorkerInterface::Observer {
url, file_type, file_status, sync_action, direction));
}
- virtual void UpdateServiceState(RemoteServiceState state,
- const std::string& description) override {
+ void UpdateServiceState(RemoteServiceState state,
+ const std::string& description) override {
if (ui_task_runner_->RunsTasksOnCurrentThread()) {
if (sync_engine_)
sync_engine_->UpdateServiceState(state, description);

Powered by Google App Engine
This is Rietveld 408576698