Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h
diff --git a/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h b/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h
index e542fd7b07ab837d463828695fb420900198bcab..1f5c5369e620c396d7c4b5f66af695da09830686 100644
--- a/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h
+++ b/chrome/browser/sync_file_system/drive_backend/drive_service_on_worker.h
@@ -30,118 +30,118 @@ class DriveServiceOnWorker : public drive::DriveServiceInterface {
const base::WeakPtr<DriveServiceWrapper>& wrapper,
base::SingleThreadTaskRunner* ui_task_runner,
base::SequencedTaskRunner* worker_task_runner);
- virtual ~DriveServiceOnWorker();
+ ~DriveServiceOnWorker() override;
- virtual google_apis::CancelCallback AddNewDirectory(
+ google_apis::CancelCallback AddNewDirectory(
const std::string& parent_resource_id,
const std::string& directory_title,
const AddNewDirectoryOptions& options,
const google_apis::FileResourceCallback& callback) override;
- virtual google_apis::CancelCallback DeleteResource(
+ google_apis::CancelCallback DeleteResource(
const std::string& resource_id,
const std::string& etag,
const google_apis::EntryActionCallback& callback) override;
- virtual google_apis::CancelCallback DownloadFile(
+ google_apis::CancelCallback DownloadFile(
const base::FilePath& local_cache_path,
const std::string& resource_id,
const google_apis::DownloadActionCallback& download_action_callback,
const google_apis::GetContentCallback& get_content_callback,
const google_apis::ProgressCallback& progress_callback) override;
- virtual google_apis::CancelCallback GetAboutResource(
+ google_apis::CancelCallback GetAboutResource(
const google_apis::AboutResourceCallback& callback) override;
- virtual google_apis::CancelCallback GetChangeList(
+ google_apis::CancelCallback GetChangeList(
int64 start_changestamp,
const google_apis::ChangeListCallback& callback) override;
- virtual google_apis::CancelCallback GetRemainingChangeList(
+ google_apis::CancelCallback GetRemainingChangeList(
const GURL& next_link,
const google_apis::ChangeListCallback& callback) override;
- virtual std::string GetRootResourceId() const override;
+ std::string GetRootResourceId() const override;
- virtual google_apis::CancelCallback GetRemainingFileList(
+ google_apis::CancelCallback GetRemainingFileList(
const GURL& next_link,
const google_apis::FileListCallback& callback) override;
- virtual google_apis::CancelCallback GetFileResource(
+ google_apis::CancelCallback GetFileResource(
const std::string& resource_id,
const google_apis::FileResourceCallback& callback) override;
- virtual google_apis::CancelCallback GetFileListInDirectory(
+ google_apis::CancelCallback GetFileListInDirectory(
const std::string& directory_resource_id,
const google_apis::FileListCallback& callback) override;
- virtual google_apis::CancelCallback RemoveResourceFromDirectory(
+ google_apis::CancelCallback RemoveResourceFromDirectory(
const std::string& parent_resource_id,
const std::string& resource_id,
const google_apis::EntryActionCallback& callback) override;
- virtual google_apis::CancelCallback SearchByTitle(
+ google_apis::CancelCallback SearchByTitle(
const std::string& title,
const std::string& directory_resource_id,
const google_apis::FileListCallback& callback) override;
- virtual bool HasRefreshToken() const override;
+ bool HasRefreshToken() const override;
// Following virtual methods are expected not to be accessed at all.
- virtual void Initialize(const std::string& account_id) override;
- virtual void AddObserver(drive::DriveServiceObserver* observer) override;
- virtual void RemoveObserver(drive::DriveServiceObserver* observer) override;
- virtual bool CanSendRequest() const override;
- virtual bool HasAccessToken() const override;
- virtual void RequestAccessToken(
+ void Initialize(const std::string& account_id) override;
+ void AddObserver(drive::DriveServiceObserver* observer) override;
+ void RemoveObserver(drive::DriveServiceObserver* observer) override;
+ bool CanSendRequest() const override;
+ bool HasAccessToken() const override;
+ void RequestAccessToken(
const google_apis::AuthStatusCallback& callback) override;
- virtual void ClearAccessToken() override;
- virtual void ClearRefreshToken() override;
- virtual google_apis::CancelCallback GetAllFileList(
+ void ClearAccessToken() override;
+ void ClearRefreshToken() override;
+ google_apis::CancelCallback GetAllFileList(
const google_apis::FileListCallback& callback) override;
- virtual google_apis::CancelCallback Search(
+ google_apis::CancelCallback Search(
const std::string& search_query,
const google_apis::FileListCallback& callback) override;
- virtual google_apis::CancelCallback GetShareUrl(
+ google_apis::CancelCallback GetShareUrl(
const std::string& resource_id,
const GURL& embed_origin,
const google_apis::GetShareUrlCallback& callback) override;
- virtual google_apis::CancelCallback GetAppList(
+ google_apis::CancelCallback GetAppList(
const google_apis::AppListCallback& callback) override;
- virtual google_apis::CancelCallback TrashResource(
+ google_apis::CancelCallback TrashResource(
const std::string& resource_id,
const google_apis::EntryActionCallback& callback) override;
- virtual google_apis::CancelCallback CopyResource(
+ google_apis::CancelCallback CopyResource(
const std::string& resource_id,
const std::string& parent_resource_id,
const std::string& new_title,
const base::Time& last_modified,
const google_apis::FileResourceCallback& callback) override;
- virtual google_apis::CancelCallback UpdateResource(
+ google_apis::CancelCallback UpdateResource(
const std::string& resource_id,
const std::string& parent_resource_id,
const std::string& new_title,
const base::Time& last_modified,
const base::Time& last_viewed_by_me,
const google_apis::FileResourceCallback& callback) override;
- virtual google_apis::CancelCallback AddResourceToDirectory(
+ google_apis::CancelCallback AddResourceToDirectory(
const std::string& parent_resource_id,
const std::string& resource_id,
const google_apis::EntryActionCallback& callback) override;
- virtual google_apis::CancelCallback InitiateUploadNewFile(
+ google_apis::CancelCallback InitiateUploadNewFile(
const std::string& content_type,
int64 content_length,
const std::string& parent_resource_id,
const std::string& title,
const InitiateUploadNewFileOptions& options,
const google_apis::InitiateUploadCallback& callback) override;
- virtual google_apis::CancelCallback InitiateUploadExistingFile(
+ google_apis::CancelCallback InitiateUploadExistingFile(
const std::string& content_type,
int64 content_length,
const std::string& resource_id,
const InitiateUploadExistingFileOptions& options,
const google_apis::InitiateUploadCallback& callback) override;
- virtual google_apis::CancelCallback ResumeUpload(
+ google_apis::CancelCallback ResumeUpload(
const GURL& upload_url,
int64 start_position,
int64 end_position,
@@ -150,18 +150,18 @@ class DriveServiceOnWorker : public drive::DriveServiceInterface {
const base::FilePath& local_file_path,
const google_apis::drive::UploadRangeCallback& callback,
const google_apis::ProgressCallback& progress_callback) override;
- virtual google_apis::CancelCallback GetUploadStatus(
+ google_apis::CancelCallback GetUploadStatus(
const GURL& upload_url,
int64 content_length,
const google_apis::drive::UploadRangeCallback& callback) override;
- virtual google_apis::CancelCallback AuthorizeApp(
+ google_apis::CancelCallback AuthorizeApp(
const std::string& resource_id,
const std::string& app_id,
const google_apis::AuthorizeAppCallback& callback) override;
- virtual google_apis::CancelCallback UninstallApp(
+ google_apis::CancelCallback UninstallApp(
const std::string& app_id,
const google_apis::EntryActionCallback& callback) override;
- virtual google_apis::CancelCallback AddPermission(
+ google_apis::CancelCallback AddPermission(
const std::string& resource_id,
const std::string& email,
google_apis::drive::PermissionRole role,
« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc ('k') | chrome/browser/sync_file_system/drive_backend/drive_uploader_on_worker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698