chrome/browser/sync_file_system/local/syncable_file_operation_runner.h - Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/syncable_file_operation_runner.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/local/sync_file_system_backend.h ('k') | chrome/browser/sync_file_system/local/syncable_file_system_operation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/syncable_file_operation_runner.h

diff --git a/chrome/browser/sync_file_system/local/syncable_file_operation_runner.h b/chrome/browser/sync_file_system/local/syncable_file_operation_runner.h

index 8d18818605a1238e1924ddcf84dd57e0e12a180c..0005ab2d4ad17a979faf74a9a744626673839486 100644

--- a/chrome/browser/sync_file_system/local/syncable_file_operation_runner.h

+++ b/chrome/browser/sync_file_system/local/syncable_file_operation_runner.h

@@ -54,11 +54,11 @@ class SyncableFileOperationRunner

SyncableFileOperationRunner(int64 max_inflight_tasks,

LocalFileSyncStatus* sync_status);

- virtual ~SyncableFileOperationRunner();

+ ~SyncableFileOperationRunner() override;

// LocalFileSyncStatus::Observer overrides.

- virtual void OnSyncEnabled(const storage::FileSystemURL& url) override;

- virtual void OnWriteEnabled(const storage::FileSystemURL& url) override;

+ void OnSyncEnabled(const storage::FileSystemURL& url) override;

+ void OnWriteEnabled(const storage::FileSystemURL& url) override;

// Runs the given |task| if no sync operation is running on any of

// its target_paths(). This also runs pending tasks that have become