chrome/browser/sync_file_system/fake_remote_change_processor.h - Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/fake_remote_change_processor.h

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/uninstall_app_task.h ('k') | chrome/browser/sync_file_system/local/canned_syncable_file_system.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/fake_remote_change_processor.h

diff --git a/chrome/browser/sync_file_system/fake_remote_change_processor.h b/chrome/browser/sync_file_system/fake_remote_change_processor.h

index f751bca7c36dc0cbfff01518079c58e9c8de36d9..48bfa8d240e38910f316526d6c7d55500328da2e 100644

--- a/chrome/browser/sync_file_system/fake_remote_change_processor.h

+++ b/chrome/browser/sync_file_system/fake_remote_change_processor.h

@@ -38,24 +38,22 @@ class FakeRemoteChangeProcessor : public RemoteChangeProcessor {

storage::FileSystemURL::Comparator> URLToFileMetadata;

FakeRemoteChangeProcessor();

- virtual ~FakeRemoteChangeProcessor();

+ ~FakeRemoteChangeProcessor() override;

// RemoteChangeProcessor overrides.

- virtual void PrepareForProcessRemoteChange(

+ void PrepareForProcessRemoteChange(

const storage::FileSystemURL& url,

const PrepareChangeCallback& callback) override;

- virtual void ApplyRemoteChange(const FileChange& change,

- const base::FilePath& local_path,

- const storage::FileSystemURL& url,

- const SyncStatusCallback& callback) override;

- virtual void FinalizeRemoteSync(

- const storage::FileSystemURL& url,

- bool clear_local_changes,

- const base::Closure& completion_callback) override;

- virtual void RecordFakeLocalChange(

- const storage::FileSystemURL& url,

- const FileChange& change,

- const SyncStatusCallback& callback) override;

+ void ApplyRemoteChange(const FileChange& change,

+ const base::FilePath& local_path,

+ const storage::FileSystemURL& url,

+ const SyncStatusCallback& callback) override;

+ void FinalizeRemoteSync(const storage::FileSystemURL& url,

+ bool clear_local_changes,

+ const base::Closure& completion_callback) override;

+ void RecordFakeLocalChange(const storage::FileSystemURL& url,

+ const FileChange& change,

+ const SyncStatusCallback& callback) override;

void UpdateLocalFileMetadata(const storage::FileSystemURL& url,

const FileChange& change);