chrome/browser/sync_file_system/local/syncable_file_system_operation.cc - Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/local/syncable_file_system_operation.cc

Issue 666143002: Standardize usage of virtual/override/final in chrome/browser/sync_file_system/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/local/syncable_file_system_operation.h ('k') | chrome/browser/sync_file_system/sync_file_system_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/local/syncable_file_system_operation.cc

diff --git a/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc b/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc

index 91989124b284a8e9df3e2668dbab0573fae30b38..5a2e7b57738acee0c764a8fa21531ec447fade3f 100644

--- a/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc

+++ b/chrome/browser/sync_file_system/local/syncable_file_system_operation.cc

@@ -40,11 +40,9 @@ class SyncableFileSystemOperation::QueueableTask

task_(task),

target_paths_(operation->target_paths_) {}

- virtual ~QueueableTask() {

- DCHECK(!operation_);

- }

+ ~QueueableTask() override { DCHECK(!operation_); }

- virtual void Run() override {

+ void Run() override {

if (!operation_)

return;

DCHECK(!task_.is_null());

@@ -52,7 +50,7 @@ class SyncableFileSystemOperation::QueueableTask

operation_.reset();

}

- virtual void Cancel() override {

+ void Cancel() override {

DCHECK(!task_.is_null());

if (operation_)

operation_->OnCancelled();

@@ -60,7 +58,7 @@ class SyncableFileSystemOperation::QueueableTask

operation_.reset();

}

- virtual const std::vector<FileSystemURL>& target_paths() const override {

+ const std::vector<FileSystemURL>& target_paths() const override {

return target_paths_;

}