requestAutocomplete (desktop): don't get stuck in infinite loop

requestAutocomplete (desktop): don't get stuck in infinite loop
when passive auth fails

tl;dr: when passive auth fails, go to accounts.google.com/ServiceLogin rather than accounts.google.com/AddAccount

BUG=323327
Committed: https://crrev.com/530bf8fcc17ca05b87e27c9a9705a59ee5f09b22
Cr-Commit-Position: refs/heads/master@{#300396}

[Evan Stade, 2014-10-16 22:42:04]

estade@chromium.org changed reviewers:
+ groby@chromium.org

[groby-ooo-7-16, 2014-10-17 20:14:12]

LGTM (I'd love a test, though - unless it's a pain)

https://codereview.chromium.org/663643002/diff/20001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/663643002/diff/20001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2629: if
(handling_use_wallet_link_click_ || GetWalletClient()->user_index() != 0) {
Mind hoisting the comment (minus TODO) over? It's somewhat clear from the
function name/user_index test, but it wouldn't hurt to spell it out.

[Evan Stade, 2014-10-17 20:43:19]

The most meaningful test would be to make sure that the URL we hit after passive
auth is capable of active auth, but I have no idea how to verify that.

https://codereview.chromium.org/663643002/diff/20001/chrome/browser/ui/autofi...
File chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc (right):

https://codereview.chromium.org/663643002/diff/20001/chrome/browser/ui/autofi...
chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc:2629: if
(handling_use_wallet_link_click_ || GetWalletClient()->user_index() != 0) {
On 2014/10/17 20:14:12, groby wrote:
> Mind hoisting the comment (minus TODO) over? It's somewhat clear from the
> function name/user_index test, but it wouldn't hurt to spell it out. 

Done.

[groby-ooo-7-16, 2014-10-17 21:49:35]

Yeah, I feared it would be hard to test :(

SLGTM

[Evan Stade, 2014-10-17 22:05:21]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-10-17 22:06:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663643002/60001

[commit-bot: I haz the power, 2014-10-17 22:35:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-17 22:36:00]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2014-10-20 23:31:46]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-10-20 23:33:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/663643002/80001

[commit-bot: I haz the power, 2014-10-21 01:33:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-21 01:35:52]

Patchset 5 (id:??) landed as
https://crrev.com/530bf8fcc17ca05b87e27c9a9705a59ee5f09b22
Cr-Commit-Position: refs/heads/master@{#300396}