Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6351)

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views.cc

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/autofill/autofill_dialog_views.cc
diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
index 3e06ab6629d4c5748d5159b456619ab96e2d2dfe..33d6d9168c87b6b41189ee99b7aca5183724ca86 100644
--- a/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views.cc
@@ -1403,7 +1403,8 @@ bool AutofillDialogViews::SaveDetailsLocally() {
return save_in_chrome_checkbox_->checked();
}
-const content::NavigationController* AutofillDialogViews::ShowSignIn() {
+const content::NavigationController* AutofillDialogViews::ShowSignIn(
+ const GURL& url) {
// The initial minimum width and height are set such that the dialog
// won't change size before the page is loaded.
int min_width = GetContentsBounds().width();
@@ -1418,7 +1419,7 @@ const content::NavigationController* AutofillDialogViews::ShowSignIn() {
sign_in_web_view_->GetWebContents(),
delegate_->GetWebContents(),
gfx::Size(min_width, min_height), GetMaximumSignInViewSize()));
- sign_in_web_view_->LoadInitialURL(delegate_->SignInUrl());
+ sign_in_web_view_->LoadInitialURL(url);
ShowDialogInMode(SIGN_IN);

Powered by Google App Engine
This is Rietveld 408576698