Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix tests Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h" 5 #include "chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/mac/scoped_nsobject.h" 8 #include "base/mac/scoped_nsobject.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/strings/sys_string_conversions.h" 10 #include "base/strings/sys_string_conversions.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 } 105 }
106 106
107 base::string16 AutofillDialogCocoa::GetCvc() { 107 base::string16 AutofillDialogCocoa::GetCvc() {
108 return base::SysNSStringToUTF16([sheet_delegate_ getCvc]); 108 return base::SysNSStringToUTF16([sheet_delegate_ getCvc]);
109 } 109 }
110 110
111 bool AutofillDialogCocoa::SaveDetailsLocally() { 111 bool AutofillDialogCocoa::SaveDetailsLocally() {
112 return [sheet_delegate_ saveDetailsLocally]; 112 return [sheet_delegate_ saveDetailsLocally];
113 } 113 }
114 114
115 const content::NavigationController* AutofillDialogCocoa::ShowSignIn() { 115 const content::NavigationController* AutofillDialogCocoa::ShowSignIn(
116 return [sheet_delegate_ showSignIn]; 116 const GURL& url) {
117 return [sheet_delegate_ showSignIn:url];
117 } 118 }
118 119
119 void AutofillDialogCocoa::HideSignIn() { 120 void AutofillDialogCocoa::HideSignIn() {
120 [sheet_delegate_ hideSignIn]; 121 [sheet_delegate_ hideSignIn];
121 } 122 }
122 123
123 void AutofillDialogCocoa::ModelChanged() { 124 void AutofillDialogCocoa::ModelChanged() {
124 [sheet_delegate_ modelChanged]; 125 [sheet_delegate_ modelChanged];
125 } 126 }
126 127
(...skipping 11 matching lines...) Expand all
138 } 139 }
139 140
140 void AutofillDialogCocoa::OnConstrainedWindowClosed( 141 void AutofillDialogCocoa::OnConstrainedWindowClosed(
141 ConstrainedWindowMac* window) { 142 ConstrainedWindowMac* window) {
142 constrained_window_.reset(); 143 constrained_window_.reset();
143 // |this| belongs to |delegate_|, so no self-destruction here. 144 // |this| belongs to |delegate_|, so no self-destruction here.
144 delegate_->ViewClosed(); 145 delegate_->ViewClosed();
145 } 146 }
146 147
147 } // autofill 148 } // autofill
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698