requestAutocomplete (desktop): don't get stuck in infinite loop

chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 123 matching lines @@
         sign_in_user_index_(0U),
         weak_ptr_factory_(this) {
     test_manager_.Init(
         NULL,
         Profile::FromBrowserContext(contents->GetBrowserContext())->GetPrefs(),
         false);
   }
 
   virtual ~TestAutofillDialogController() {}
 
-  virtual GURL SignInUrl() const override {
+  GURL FakeSignInUrl() const {
     return GURL(chrome::kChromeUIVersionURL);
   }
 
+  virtual void ShowSignIn(const GURL& url) override {
+    AutofillDialogControllerImpl::ShowSignIn(FakeSignInUrl());
+  }
+
   virtual void ViewClosed() override {
     message_loop_runner_->Quit();
     AutofillDialogControllerImpl::ViewClosed();
   }
 
   virtual base::string16 InputValidityMessage(
       DialogSection section,
       ServerFieldType type,
       const base::string16& value) override {
     if (!use_validation_)
@@ skipping 1009 matching lines @@
       ::prefs::kAutofillDialogPayWithoutWallet,
       true);
 
   InitializeController();
 
   controller()->OnDidFetchWalletCookieValue(std::string());
   controller()->OnDidGetWalletItems(
       wallet::GetTestWalletItemsWithRequiredAction(wallet::GAIA_AUTH));
 
   NavEntryCommittedObserver sign_in_page_observer(
-      controller()->SignInUrl(),
+      controller()->FakeSignInUrl(),
       content::NotificationService::AllSources());
 
   // Simulate a user clicking "Sign In" (which loads dialog's web contents).
   controller()->SignInLinkClicked();
   EXPECT_TRUE(controller()->ShouldShowSignInWebView());
 
   scoped_ptr<AutofillDialogViewTester> view = GetViewTester();
   content::WebContents* sign_in_contents = view->GetSignInWebContents();
   ASSERT_TRUE(sign_in_contents);
 
   sign_in_page_observer.Wait();
 
   NavEntryCommittedObserver continue_page_observer(
       wallet::GetSignInContinueUrl(),
       content::NotificationService::AllSources());
 
-  EXPECT_EQ(sign_in_contents->GetURL(), controller()->SignInUrl());
+  EXPECT_EQ(sign_in_contents->GetURL(), controller()->FakeSignInUrl());
 
   AccountChooserModel* account_chooser_model =
       controller()->AccountChooserModelForTesting();
   EXPECT_FALSE(account_chooser_model->WalletIsSelected());
 
   content::OpenURLParams params(wallet::GetSignInContinueUrl(),
                                 content::Referrer(),
                                 CURRENT_TAB,
                                 ui::PAGE_TRANSITION_LINK,
                                 true);
@@ skipping 38 matching lines @@
   controller()->OnDidGetWalletItems(
       wallet::GetTestWalletItemsWithUsers(usernames, 0));
 
   // Switch to Autofill.
   AccountChooserModel* account_chooser_model =
       controller()->AccountChooserModelForTesting();
   account_chooser_model->ActivatedAt(
       account_chooser_model->GetItemCount() - 1);
 
   NavEntryCommittedObserver sign_in_page_observer(
-      controller()->SignInUrl(),
+      controller()->FakeSignInUrl(),
       content::NotificationService::AllSources());
 
   // Simulate a user clicking "add account".
   account_chooser_model->ActivatedAt(
       account_chooser_model->GetItemCount() - 2);
   EXPECT_TRUE(controller()->ShouldShowSignInWebView());
 
   scoped_ptr<AutofillDialogViewTester> view = GetViewTester();
   content::WebContents* sign_in_contents = view->GetSignInWebContents();
   ASSERT_TRUE(sign_in_contents);
 
   sign_in_page_observer.Wait();
 
   NavEntryCommittedObserver continue_page_observer(
       wallet::GetSignInContinueUrl(),
       content::NotificationService::AllSources());
 
-  EXPECT_EQ(sign_in_contents->GetURL(), controller()->SignInUrl());
+  EXPECT_EQ(sign_in_contents->GetURL(), controller()->FakeSignInUrl());
 
   EXPECT_FALSE(account_chooser_model->WalletIsSelected());
 
   // User signs into new account, account 3.
   controller()->set_sign_in_user_index(3U);
   content::OpenURLParams params(wallet::GetSignInContinueUrl(),
                                 content::Referrer(),
                                 CURRENT_TAB,
                                 ui::PAGE_TRANSITION_LINK,
                                 true);
@@ skipping 118 matching lines @@
   EXPECT_EQ(3, tab_strip->GetIndexOfWebContents(blank_tab));
 }
 
 IN_PROC_BROWSER_TEST_F(AutofillDialogControllerTest,
                        SignInWebViewOpensLinksInNewTab) {
   controller()->OnDidFetchWalletCookieValue(std::string());
   controller()->OnDidGetWalletItems(
       wallet::GetTestWalletItemsWithRequiredAction(wallet::GAIA_AUTH));
 
   NavEntryCommittedObserver sign_in_page_observer(
-      controller()->SignInUrl(),
+      controller()->FakeSignInUrl(),
       content::NotificationService::AllSources());
 
   controller()->SignInLinkClicked();
 
   content::WebContents* sign_in_contents =
       GetViewTester()->GetSignInWebContents();
   ASSERT_TRUE(sign_in_contents);
 
   sign_in_page_observer.Wait();
 
@@ skipping 360 matching lines @@
       "<input autocomplete='transaction-currency' value='USD' readonly>"
       "<input autocomplete='cc-csc'>");
   AutofillDialogControllerImpl* controller = SetUpHtmlAndInvoke(html);
   ASSERT_TRUE(controller);
 
   EXPECT_EQ(ASCIIToUTF16("24"), controller->transaction_amount_);
   EXPECT_EQ(ASCIIToUTF16("USD"), controller->transaction_currency_);
 }
 
 }  // namespace autofill