chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.h ('k') | chrome/browser/ui/views/autofill/autofill_dialog_views.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm

index 3cdd4479c323ecb0d1368e6b261aea6a1df8cc8d..ed50f1f1db01eb4c53e1cbcf401aa01ecc5de63e 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_sign_in_container.mm

@@ -80,7 +80,7 @@ void CocoaSignInDelegate::HandleKeyboardEvent(

[self setView:webContentView];

}

-- (void)loadSignInPage {

+- (void)loadSignInPage:(const GURL&)url {

DCHECK(webContents_.get());

// Ensure initial minimum size doesn't cause resize.

@@ -98,11 +98,10 @@ void CocoaSignInDelegate::HandleKeyboardEvent(

gfx::Size(NSSizeToCGSize(initialMinSize)),

gfx::Size(NSSizeToCGSize(maxSize_)),

[self view]));

- webContents_->GetController().LoadURL(

- dialog_->delegate()->SignInUrl(),

- content::Referrer(),

- ui::PAGE_TRANSITION_AUTO_TOPLEVEL,

- std::string());

+ webContents_->GetController().LoadURL(url,

+ content::Referrer(),

+ ui::PAGE_TRANSITION_AUTO_TOPLEVEL,

+ std::string());

}

- (content::NavigationController*)navigationController {