chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

index 3c11a9c68deb231047c2cd8eeaea47d75be1d919..c13d1591b3a2ce860b0a69fb3578b0a3e7c82cf3 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc

@@ -210,7 +210,8 @@ class TestAutofillDialogView : public AutofillDialogView {

return save_details_locally_checked_;

}

- virtual const content::NavigationController* ShowSignIn() override {

+ virtual const content::NavigationController* ShowSignIn(const GURL& url)

+ override {

return NULL;

}

virtual void HideSignIn() override {}

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_view.h » ('j') | no next file with comments »