chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h ('k') | chrome/browser/ui/cocoa/autofill/autofill_dialog_window_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

index dd6f2ffaf07878c884e8a691d90b07b308fc30b4..f6ab0064b6de3bde6c36072813f1ce857ce2651b 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

+++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm

@@ -112,8 +112,9 @@ bool AutofillDialogCocoa::SaveDetailsLocally() {

return [sheet_delegate_ saveDetailsLocally];

}

-const content::NavigationController* AutofillDialogCocoa::ShowSignIn() {

- return [sheet_delegate_ showSignIn];

+const content::NavigationController* AutofillDialogCocoa::ShowSignIn(

+ const GURL& url) {

+ return [sheet_delegate_ showSignIn:url];

}

void AutofillDialogCocoa::HideSignIn() {