chrome/browser/ui/autofill/autofill_dialog_view.h - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_view.h

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_view_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_view.h

diff --git a/chrome/browser/ui/autofill/autofill_dialog_view.h b/chrome/browser/ui/autofill/autofill_dialog_view.h

index 822f21a3b4602657a1824f7838af39563172dda8..bc8312dc7a170a154cda58430350f6ecec0de28c 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_view.h

+++ b/chrome/browser/ui/autofill/autofill_dialog_view.h

@@ -84,7 +84,7 @@ class AutofillDialogView {

// Triggers dialog to sign in to Google.

// Returns a NotificationSource to be used to monitor for sign-in completion.

- virtual const content::NavigationController* ShowSignIn() = 0;

+ virtual const content::NavigationController* ShowSignIn(const GURL& url) = 0;

// Closes out any sign-in UI and returns to normal operation.

virtual void HideSignIn() = 0;