chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/autofill/autofill_dialog_views.cc ('k') | components/autofill/content/browser/wallet/wallet_service_url.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc

diff --git a/chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc b/chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc

index 1ee0507a55035fed422939fecf90e0f7c428cedf..096409b81d95ccc210ce3b1ba441b2e0c8f9dda4 100644

--- a/chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc

+++ b/chrome/browser/ui/views/autofill/autofill_dialog_views_unittest.cc

@@ -12,6 +12,7 @@

#include "chrome/browser/ui/views/autofill/decorated_textfield.h"

#include "chrome/browser/ui/views/frame/browser_view.h"

#include "chrome/browser/ui/views/frame/test_with_browser_view.h"

+#include "components/autofill/content/browser/wallet/wallet_service_url.h"

#include "components/web_modal/test_web_contents_modal_dialog_host.h"

#include "components/web_modal/test_web_contents_modal_dialog_manager_delegate.h"

#include "components/web_modal/web_contents_modal_dialog_manager.h"

@@ -124,7 +125,7 @@ TEST_F(AutofillDialogViewsTest, SignInFocus) {

views::View* notification_area = dialog()->GetNotificationAreaForTesting();

views::View* scrollable_area = dialog()->GetScrollableAreaForTesting();

- dialog()->ShowSignIn();

+ dialog()->ShowSignIn(wallet::GetAddAccountUrl());

// The sign in view should be the only showing and focusable view.

EXPECT_TRUE(sign_in_web_view->IsFocusable());

@@ -141,7 +142,7 @@ TEST_F(AutofillDialogViewsTest, SignInFocus) {

EXPECT_FALSE(loading_shield->IsFocusable());

EXPECT_FALSE(sign_in_web_view->IsFocusable());

- dialog()->ShowSignIn();

+ dialog()->ShowSignIn(wallet::GetAddAccountUrl());

EXPECT_TRUE(sign_in_web_view->IsFocusable());

EXPECT_FALSE(loading_shield->IsFocusable());