chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_view_delegate.h ('k') | chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h

diff --git a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h

index e8aa620784e368e6be4565c461d3fc9fe1bb8391..f02f5381eb4d7c620f1bebd70fe6190eadeb7529 100644

--- a/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h

+++ b/chrome/browser/ui/cocoa/autofill/autofill_dialog_cocoa.h

@@ -51,7 +51,8 @@ class AutofillDialogCocoa : public AutofillDialogView,

FieldValueMap* output) override;

virtual base::string16 GetCvc() override;

virtual bool SaveDetailsLocally() override;

- virtual const content::NavigationController* ShowSignIn() override;

+ virtual const content::NavigationController* ShowSignIn(

+ const GURL& url) override;

virtual void HideSignIn() override;

virtual void ModelChanged() override;

virtual void OnSignInResize(const gfx::Size& pref_size) override;