chrome/browser/ui/autofill/autofill_dialog_controller_impl.h - Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

Issue 663643002: requestAutocomplete (desktop): don't get stuck in infinite loop (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix tests Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/autofill/autofill_dialog_controller_browsertest.cc ('k') | chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

index fe52e571a6edcdbfc0aa2da33a9b53c88a850906..bc1904847438ebd27ca5cde26cbf00152d116f58 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.h

@@ -113,7 +113,6 @@ class AutofillDialogControllerImpl

virtual bool ShouldShowSpinner() const override;

virtual bool ShouldShowAccountChooser() const override;

virtual bool ShouldShowSignInWebView() const override;

- virtual GURL SignInUrl() const override;

virtual bool ShouldOfferToSaveInChrome() const override;

virtual bool ShouldSaveInChrome() const override;

virtual ui::MenuModel* MenuModelForAccountChooser() override;

@@ -327,6 +326,9 @@ class AutofillDialogControllerImpl

// Whether the user is known to be signed in.

DialogSignedInState SignedInState() const;

+ // Tells the view to shows the webpage at |url|. Virtual for testing.

+ virtual void ShowSignIn(const GURL& url);

private:

FRIEND_TEST_ALL_PREFIXES(AutofillDialogControllerI18nTest,

CorrectCountryFromInputs);