Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
James Hawkins
CC:
avayvod+watch_chromium.org, benquan, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, davidben+watch_chromium.org, David Black, Dane Wallinga, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, dyu1, estade+watch_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, gavinp+prer_chromium.org, groby+spellwatch_chromium.org, grt+watch_chromium.org, hclam+watch_chromium.org, hguihot+watch_chromium.org, hubbe+watch_chromium.org, imcheng+watch_chromium.org, Ilya Sherman, jasonroberts+watch_google.com, Jered, jfweitz+watch_chromium.org, jkarlin+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, mikhal+watch_chromium.org, miu+watch_chromium.org, mkwst+moarreviews-ipc_chromium.org, pwestin+watch_google.com, rlp+watch_chromium.org, rouslan+autofillwatch_chromium.org, rouslan+spellwatch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org, tburkard+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/renderer/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=jhawkins@chromium.org Committed: https://crrev.com/b228d038b3bc109dc9548219a2599e3b7531619b Cr-Commit-Position: refs/heads/master@{#300451}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+322 lines, -348 lines) Patch
M chrome/renderer/autofill/page_click_tracker_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.h View 1 chunk +60 lines, -65 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/chrome_mock_render_thread.h View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_render_process_observer.cc View 2 chunks +6 lines, -8 lines 0 comments Download
M chrome/renderer/chrome_render_view_observer.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/renderer/content_settings_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/app_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/automation_internal_custom_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/cast_streaming_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h View 1 chunk +14 lines, -15 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_renderer_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/extensions/chrome_v8_extension_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/extension_frame_helper.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/renderer/extensions/extension_localization_peer.h View 2 chunks +15 lines, -17 lines 0 comments Download
M chrome/renderer/extensions/renderer_permissions_policy_delegate.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/renderer/extensions/tab_finder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/extensions/webstore_bindings.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/external_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/loadtimes_extension_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/media/cast_ipc_dispatcher.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/renderer/media/cast_rtp_stream.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/renderer/media/cast_transport_sender_ipc.h View 1 chunk +11 lines, -13 lines 0 comments Download
M chrome/renderer/media/chrome_webrtc_log_message_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/mock_webrtc_logging_message_filter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/net/net_error_helper.h View 3 chunks +21 lines, -22 lines 0 comments Download
M chrome/renderer/net/net_error_page_controller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/net_benchmarking_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/page_load_histograms.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/chrome_pdf_print_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/renderer/pepper/chrome_renderer_pepper_host_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_drm_renderer_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_font_file_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_fullscreen_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_menu_host.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/pepper/pepper_flash_renderer_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_shared_memory_message_filter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/pepper/pepper_uma_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/plugins/chrome_plugin_placeholder.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/renderer/plugins/plugin_uma.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/renderer/prefetch_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/prerender/prerender_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/prerender/prerender_helper.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/prerender/prerender_media_load_deferrer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/prerender/prerenderer_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/principals_extension_bindings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/printing/print_web_view_helper.h View 2 chunks +5 lines, -6 lines 0 comments Download
M chrome/renderer/printing/print_web_view_helper_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/malware_dom_details.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/safe_browsing/phishing_classifier_delegate.h View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/searchbox/search_bouncer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/searchbox/searchbox_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/security_filter_peer.h View 4 chunks +37 lines, -43 lines 0 comments Download
M chrome/renderer/spellchecker/cocoa_spelling_engine_mac.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/renderer/spellchecker/hunspell_engine.h View 1 chunk +6 lines, -7 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_provider_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/renderer/tts_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 09:58:56 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663333002/1
6 years, 2 months ago (2014-10-21 10:00:45 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:05:45 UTC) #4
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:06:28 UTC) #5
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/b228d038b3bc109dc9548219a2599e3b7531619b
Cr-Commit-Position: refs/heads/master@{#300451}

Powered by Google App Engine
This is Rietveld 408576698