chrome/renderer/printing/print_web_view_helper_browsertest.cc - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/printing/print_web_view_helper_browsertest.cc

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/printing/print_web_view_helper_browsertest.cc

diff --git a/chrome/renderer/printing/print_web_view_helper_browsertest.cc b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

index e2ff37aab7967151b040203d31f6c9ead7091182..5e45e767fd591590ad45bbf79e53fb4f80df6da8 100644

--- a/chrome/renderer/printing/print_web_view_helper_browsertest.cc

+++ b/chrome/renderer/printing/print_web_view_helper_browsertest.cc

@@ -110,7 +110,7 @@ class DidPreviewPageListener : public IPC::Listener {

explicit DidPreviewPageListener(base::RunLoop* run_loop)

: run_loop_(run_loop) {}

- virtual bool OnMessageReceived(const IPC::Message& message) override {

+ bool OnMessageReceived(const IPC::Message& message) override {

if (message.type() == PrintHostMsg_MetafileReadyForPrinting::ID ||

message.type() == PrintHostMsg_PrintPreviewFailed::ID ||

message.type() == PrintHostMsg_PrintPreviewCancelled::ID)

« no previous file with comments | « chrome/renderer/printing/print_web_view_helper.h ('k') | chrome/renderer/safe_browsing/malware_dom_details.h » ('j') | no next file with comments »