chrome/renderer/plugins/plugin_uma.cc - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/plugins/plugin_uma.cc

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/plugins/plugin_uma.cc

diff --git a/chrome/renderer/plugins/plugin_uma.cc b/chrome/renderer/plugins/plugin_uma.cc

index df26dec99d51722515ed4aab63cfe3bedcbf0e33..a66d26b9380194ca11eb2c724effa03f98244af4 100644

--- a/chrome/renderer/plugins/plugin_uma.cc

+++ b/chrome/renderer/plugins/plugin_uma.cc

@@ -36,9 +36,8 @@ const char* kShockwaveFlashExtensions[] = {".spl", ".swf"};

} // namespace.

class UMASenderImpl : public PluginUMAReporter::UMASender {

- virtual void SendPluginUMA(

- PluginUMAReporter::ReportType report_type,

- PluginUMAReporter::PluginType plugin_type) override;

+ void SendPluginUMA(PluginUMAReporter::ReportType report_type,

+ PluginUMAReporter::PluginType plugin_type) override;

};

void UMASenderImpl::SendPluginUMA(PluginUMAReporter::ReportType report_type,

« no previous file with comments | « chrome/renderer/plugins/chrome_plugin_placeholder.h ('k') | chrome/renderer/prefetch_helper.h » ('j') | no next file with comments »