chrome/renderer/searchbox/searchbox_extension.cc - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox_extension.cc

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/searchbox/searchbox_extension.cc

diff --git a/chrome/renderer/searchbox/searchbox_extension.cc b/chrome/renderer/searchbox/searchbox_extension.cc

index 2133621c4147a948fa9c18a601ae6db9f76f1705..612287b33774cd27541edfbb3f7eab5becfabc3e 100644

--- a/chrome/renderer/searchbox/searchbox_extension.cc

+++ b/chrome/renderer/searchbox/searchbox_extension.cc

@@ -341,7 +341,7 @@ class SearchBoxExtensionWrapper : public v8::Extension {

// Allows v8's javascript code to call the native functions defined

// in this class for window.chrome.

- virtual v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(

+ v8::Handle<v8::FunctionTemplate> GetNativeFunctionTemplate(

v8::Isolate*,

v8::Handle<v8::String> name) override;

« no previous file with comments | « chrome/renderer/searchbox/searchbox.h ('k') | chrome/renderer/security_filter_peer.h » ('j') | no next file with comments »