chrome/renderer/searchbox/searchbox.h - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/searchbox/searchbox.h

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/searchbox/searchbox.h

diff --git a/chrome/renderer/searchbox/searchbox.h b/chrome/renderer/searchbox/searchbox.h

index 80c1a6e107039efd8ac876d3ba3ec0adeaa06d88..e2d03c7f37d7625637005d724896f70ef31b426e 100644

--- a/chrome/renderer/searchbox/searchbox.h

+++ b/chrome/renderer/searchbox/searchbox.h

@@ -26,7 +26,7 @@ class SearchBox : public content::RenderViewObserver,

public content::RenderViewObserverTracker<SearchBox> {

public:

explicit SearchBox(content::RenderView* render_view);

- virtual ~SearchBox();

+ ~SearchBox() override;

// Sends ChromeViewHostMsg_LogEvent to the browser.

void LogEvent(NTPLoggingEventType event);

@@ -114,7 +114,7 @@ class SearchBox : public content::RenderViewObserver,

private:

// Overridden from content::RenderViewObserver:

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

void OnSetPageSequenceNumber(int page_seq_no);

void OnChromeIdentityCheckResult(const base::string16& identity,

« no previous file with comments | « chrome/renderer/searchbox/search_bouncer.h ('k') | chrome/renderer/searchbox/searchbox_extension.cc » ('j') | no next file with comments »