chrome/renderer/extensions/extension_frame_helper.h - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/extension_frame_helper.h

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/chrome_v8_extension_handler.h ('k') | chrome/renderer/extensions/extension_localization_peer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/extension_frame_helper.h

diff --git a/chrome/renderer/extensions/extension_frame_helper.h b/chrome/renderer/extensions/extension_frame_helper.h

index 54a43f5e901467bc518e53f8b197974b8b7cbe07..7f414e73da52aeca9c49a34184e0df32f27e13a9 100644

--- a/chrome/renderer/extensions/extension_frame_helper.h

+++ b/chrome/renderer/extensions/extension_frame_helper.h

@@ -20,13 +20,12 @@ class ExtensionFrameHelper

public:

ExtensionFrameHelper(content::RenderFrame* render_frame,

Dispatcher* extension_dispatcher);

- virtual ~ExtensionFrameHelper();

+ ~ExtensionFrameHelper() override;

private:

// RenderFrameObserver implementation.

- virtual void WillReleaseScriptContext(v8::Handle<v8::Context>,

- int world_id) override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void WillReleaseScriptContext(v8::Handle<v8::Context>, int world_id) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// IPC handlers.

void OnAddMessageToConsole(content::ConsoleMessageLevel level,