chrome/renderer/extensions/app_bindings.h - Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/app_bindings.h

Issue 663333002: Standardize usage of virtual/override/final in chrome/renderer/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/content_settings_observer.h ('k') | chrome/renderer/extensions/automation_internal_custom_bindings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/extensions/app_bindings.h

diff --git a/chrome/renderer/extensions/app_bindings.h b/chrome/renderer/extensions/app_bindings.h

index 76ad97ea2f95899332bcd3fec4bb48864fb270f9..908dcecf27d4b4575518a9f985d86e598ca50e21 100644

--- a/chrome/renderer/extensions/app_bindings.h

+++ b/chrome/renderer/extensions/app_bindings.h

@@ -29,7 +29,7 @@ class AppBindings : public ObjectBackedNativeHandler,

private:

// IPC::Listener

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ bool OnMessageReceived(const IPC::Message& message) override;

void GetIsInstalled(const v8::FunctionCallbackInfo<v8::Value>& args);

void GetDetails(const v8::FunctionCallbackInfo<v8::Value>& args);

« no previous file with comments | « chrome/renderer/content_settings_observer.h ('k') | chrome/renderer/extensions/automation_internal_custom_bindings.h » ('j') | no next file with comments »